This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
Prevent placeholder from unnecessarily wrapping #2392
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Safari, the placeholder text sometimes wraps into multiple lines before it reaches the full width of the editor. The addition of `width: 100%;` prevents the absolutely-positioned placeholder from trying to "shrink-wrap", which causes the unnecessarily wrapping. Steps to reproduce: 1. Open the editor with a placeholder that takes up >50% but <100% of the editor width in Safari. 2. Type a character. 3. Press backspace.
There was a problem hiding this comment.
@mrkev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
vilemj-Viclick
pushed a commit
to kontent-ai/draft-js
that referenced
this pull request
Jul 16, 2020
Summary: In Safari, the placeholder text sometimes wraps into multiple lines before it reaches the full width of the editor. The addition of `width: 100%;` prevents the absolutely-positioned placeholder from trying to "shrink-wrap", which causes the unnecessarily wrapping. Steps to reproduce: 1. Open the editor with a placeholder that takes up >50% but <100% of the editor width in Safari. 2. Type a character. 3. Press backspace. *Before* submitting a pull request, please make sure the following is done... 1. Fork the repo and create your branch from `master`. 2. If you've added code that should be tested, add tests! 3. If you've changed APIs, update the documentation. 4. Ensure that: * The test suite passes (`npm test`) * Your code lints (`npm run lint`) and passes Flow (`npm run flow`) * You have followed the [testing guidelines](https://github.com/facebook/draft-js/wiki/Testing-for-Pull-Requests) 5. If you haven't already, complete the [CLA](https://code.facebook.com/cla). Please use the simple form below as a guideline for describing your pull request. Thanks for contributing to Draft.js! - **Summary** [...] **Test Plan** [...] Pull Request resolved: facebookarchive#2392 Reviewed By: fryn Differential Revision: D21319038 Pulled By: mrkev fbshipit-source-id: b03c8afa47873ea210207aadb0225db8801bd84e
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this pull request
Jul 4, 2023
Summary: In Safari, the placeholder text sometimes wraps into multiple lines before it reaches the full width of the editor. The addition of `width: 100%;` prevents the absolutely-positioned placeholder from trying to "shrink-wrap", which causes the unnecessarily wrapping. Steps to reproduce: 1. Open the editor with a placeholder that takes up >50% but <100% of the editor width in Safari. 2. Type a character. 3. Press backspace. *Before* submitting a pull request, please make sure the following is done... 1. Fork the repo and create your branch from `master`. 2. If you've added code that should be tested, add tests! 3. If you've changed APIs, update the documentation. 4. Ensure that: * The test suite passes (`npm test`) * Your code lints (`npm run lint`) and passes Flow (`npm run flow`) * You have followed the [testing guidelines](https://github.com/facebook/draft-js/wiki/Testing-for-Pull-Requests) 5. If you haven't already, complete the [CLA](https://code.facebook.com/cla). Please use the simple form below as a guideline for describing your pull request. Thanks for contributing to Draft.js! - **Summary** [...] **Test Plan** [...] Pull Request resolved: facebookarchive/draft-js#2392 Reviewed By: fryn Differential Revision: D21319038 Pulled By: mrkev fbshipit-source-id: b03c8afa47873ea210207aadb0225db8801bd84e
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Safari, the placeholder text sometimes wraps into multiple lines before it reaches the full width of the editor.
The addition of
width: 100%;prevents the absolutely-positioned placeholder from trying to "shrink-wrap", which causes the unnecessarily wrapping.Steps to reproduce:
Before submitting a pull request, please make sure the following is done...
master.npm test)npm run lint) and passes Flow (npm run flow)Please use the simple form below as a guideline for describing your pull request.
Thanks for contributing to Draft.js!
Summary
[...]
Test Plan
[...]