This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
Address #2413 by making Firefox follow the same behaviour as Chrome #2414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@mrkev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
noahlemen
approved these changes
May 7, 2020
vilemj-Viclick
pushed a commit
to kontent-ai/draft-js
that referenced
this pull request
Jul 16, 2020
…our as Chrome (facebookarchive#2414) Summary: All info is in the facebookarchive#2413 and this [Bugzilla issue](https://bugzilla.mozilla.org/show_bug.cgi?id=1625475). Noteworthy from that Bugzilla thread is [comment 16](https://bugzilla.mozilla.org/show_bug.cgi?id=1625475#c16): > I added a selectionchange listener to the document of Twitter, and I tried reproducing this with the STR in comment 10. Then, I confirmed that selectionchange event is fired as expected both on Firefox (Nightly) and Chrome (Release) when I click middle of the text node. So, **it might be a bug of React if the onSelect is not called as expected...** This is worth future investigation, but for now let's just fix the bug. Pull Request resolved: facebookarchive#2414 Reviewed By: kedromelon Differential Revision: D21443875 Pulled By: mrkev fbshipit-source-id: 8bd099ddc44e3c4cdac679e1d605c4da5146c1e8
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this pull request
Jul 4, 2023
…#2414) Summary: All info is in the facebookarchive/draft-js#2413 and this [Bugzilla issue](https://bugzilla.mozilla.org/show_bug.cgi?id=1625475). Noteworthy from that Bugzilla thread is [comment 16](https://bugzilla.mozilla.org/show_bug.cgi?id=1625475#c16): > I added a selectionchange listener to the document of Twitter, and I tried reproducing this with the STR in comment 10. Then, I confirmed that selectionchange event is fired as expected both on Firefox (Nightly) and Chrome (Release) when I click middle of the text node. So, **it might be a bug of React if the onSelect is not called as expected...** This is worth future investigation, but for now let's just fix the bug. Pull Request resolved: facebookarchive/draft-js#2414 Reviewed By: kedromelon Differential Revision: D21443875 Pulled By: mrkev fbshipit-source-id: 8bd099ddc44e3c4cdac679e1d605c4da5146c1e8
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All info is in the #2413 and this Bugzilla issue.
Noteworthy from that Bugzilla thread is comment 16:
This is worth future investigation, but for now let's just fix the bug.
EDIT: Kept reading down the thread, and comment 21 seems to imply this is in fact not a bug in React. Still worth investigating at some point in the future.