This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
[Docs]: Add Null return value type in code example #2429
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TypeScript threw this error when I attempted to copy and paste in my code: ``` Type 'null' is not assignable to type 'string'.ts(2322) ``` The `getDefaultKeyBinding()` method may return null. So I added `| null` to the return type declaration. Just thought it would help others who may also be copying/pasting the code!
|
Yup, can confirm the type is an optional |
There was a problem hiding this comment.
@mrkev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
noahlemen
approved these changes
May 20, 2020
vilemj-Viclick
pushed a commit
to kontent-ai/draft-js
that referenced
this pull request
Jul 16, 2020
Summary: **Summary** TypeScript threw this error when I attempted to copy and paste in my code: ``` Type 'null' is not assignable to type 'string'.ts(2322) ``` The `getDefaultKeyBinding()` method may return null. So I added `| null` to the return type declaration. Just thought it would help others who may also be copying/pasting the code! **Test Plan** No testing required. Pull Request resolved: facebookarchive#2429 Reviewed By: kedromelon Differential Revision: D21652264 Pulled By: mrkev fbshipit-source-id: c820028da1ec6eb17055aceb5a751f7d01636b83
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this pull request
Jul 4, 2023
Summary: **Summary** TypeScript threw this error when I attempted to copy and paste in my code: ``` Type 'null' is not assignable to type 'string'.ts(2322) ``` The `getDefaultKeyBinding()` method may return null. So I added `| null` to the return type declaration. Just thought it would help others who may also be copying/pasting the code! **Test Plan** No testing required. Pull Request resolved: facebookarchive/draft-js#2429 Reviewed By: kedromelon Differential Revision: D21652264 Pulled By: mrkev fbshipit-source-id: c820028da1ec6eb17055aceb5a751f7d01636b83
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TypeScript threw this error when I attempted to copy and paste in my code:
The
getDefaultKeyBinding()method may return null. So I added| nullto the return type declaration. Just thought it would help others who may also be copying/pasting the code!Test Plan
No testing required.