This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
Update link to Immutable Map in docs #2530
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@mrkev has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This is awesome, thanks @agarwalrounak! |
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this pull request
Jul 4, 2023
Summary: **Summary** Map in docs, wherever mentioned, links to http://facebook.github.io/immutable-js/docs/#/Map and also in some cases to http://facebook.github.io/immutable-js/docs/#/Record/Record which then redirect to https://immutable-js.github.io/immutable-js/ However, the correct link for Map is https://immutable-js.github.io/immutable-js/docs/#/Map Draft.js uses immutable 3.7.4 which released on 18 Jun 2015 according to this commit immutable-js/immutable-js@09f04e9 I have linked `Map` to the docs for that version(captured on 23 Jun 2015) through the Internet Archive. Pull Request resolved: facebookarchive/draft-js#2530 Reviewed By: creedarky Differential Revision: D22784847 Pulled By: mrkev fbshipit-source-id: e91c92d2d26b09266bc6e53bb5e0eed0646ec60a
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Map in docs, wherever mentioned, links to http://facebook.github.io/immutable-js/docs/#/Map and also in some cases to http://facebook.github.io/immutable-js/docs/#/Record/Record which then redirect to https://immutable-js.github.io/immutable-js/
However, the correct link for Map is https://immutable-js.github.io/immutable-js/docs/#/Map
Draft.js uses immutable 3.7.4 which released on 18 Jun 2015 according to this commit immutable-js/immutable-js@09f04e9
I have linked
Mapto the docs for that version(captured on 23 Jun 2015) through the Internet Archive.