Support rendering Draft.js into iframes (nested browsing contexts) #765

acusti · 2016-11-05T03:47:22Z

Summary

Removes Draft’s dependency on the global window and document objects and makes it work across nested browsing contexts (iframes) by using the document and window relative to the browsing context in which Draft is being used. React itself makes similar assumptions about being able to use the global window and document objects, as documented in facebook/react#427, so this PR depends on facebook/react#9184. All together, these changes make it possible to render Draft.js inside an iframe, which in turn makes it possible to have a UX where the page includes multiple visible selections, like in this demo. In that demo, I used built versions of React and Draft.js which include all the changes necessary to make it work across nested browsing contexts.

Fixes #527

Test Plan

All of the unit tests are passing. For manual testing, I’ve focused on verifying the behavior of the editor when dealing with selections. That includes:

Select a portion of text and start typing to replace it
Select a portion of text and hit delete to remove it
Select a portion of text and paste in content to replace it
Select a portion of text and copy it, then paste it somewhere
Select a portion of text and cut it, then paste it somewhere

I then:

Repeated the steps above with a collapsed selection (for the insertion step)
Repeated the steps above with a selection that spans multiple blocks

Finally, I manually tested all of those behaviors with:

A regular editor implementation where the editor is inside the same browsing context as the rest of the React app
An implementation where the editor is rendered into an iframe within the parent browsing context where React is running, like with the codepen demo I linked to above

In order to make it easy to try and test these behaviors, I created installable branches of fbjs and React that include the lib/ files to make it installable and usable via npm as well as the built files to be usable directly in the browser.

Try it out via npm

In your package.json, use:

    "draft-js": "Brandcast/draft-js#f9affa3",
    "fbjs": "Brandcast/fbjs-built#97b8e54",
    "react": "Brandcast/react#9a81d1a",

Try it out in the browser

Include:

    <script src="https://rawgit.com/Brandcast/react/nested-browsing-contexts-2-built/build/react.js"></script>
    <script src="https://rawgit.com/Brandcast/react/nested-browsing-contexts-2-built/build/react-dom.js"></script>
    <script src="https://cdn.jsdelivr.net/immutable.js/latest/immutable.min.js"></script>
    <script src="https://cdn.jsdelivr.net/es6.shim/0.35.1/es6-shim.min.js"></script>
    <script src="https://cdnjs.cloudflare.com/ajax/libs/babel-core/5.8.34/browser.js"></script>
    <script src="https://rawgit.com/Brandcast/draft-js/iframe-compatibility-built/dist/Draft.js"></script>

Rendering into an iframe

To know more about rendering into an iframe, see this explanation from @ryanseddon. Also, he turned his work into the React Frame Component, which makes it trivial to try out. And to understand use cases and the utility of enabling this functionality, the major benefits are:

Enabling multiple visible selections (see the demo I mentioned above).
Proper CSS encapsulation (e.g. render a preview of something with custom CSS without worrying about loading those styles into the app window).

acusti · 2016-12-07T04:14:18Z

Just rebased with master and resolved conflicts in editOnBlur. I also updated my built versions of everything, including draft-js (v0.9.0), react (v15.4.1), and react-dom (v15.4.1), so if anyone wanted to test out the latest version of this PR built with the latest versions of the React PR (facebook/react#7936), here are the new urls / dependency strings to use.

npm / yarn

    "draft-js": "brandcast/draft-js-built#333bf90",
    "fbjs": "brandcast/fbjs-built#3961252",
    "react": "brandcast/react-built#ab31c46",
    "react-dom": "brandcast/react-dom-built#6cd1db3",

in the browser

    <script src="https://rawgit.com/brandcast/react-built/15-stable/dist/react.js"></script>
    <script src="https://rawgit.com/brandcast/react-dom-built/15-stable/dist/react-dom.js"></script>
    <script src="https://cdn.jsdelivr.net/immutable.js/latest/immutable.min.js"></script>
    <script src="https://cdn.jsdelivr.net/es6.shim/0.35.1/es6-shim.min.js"></script>
    <script src="https://cdnjs.cloudflare.com/ajax/libs/babel-core/5.8.34/browser.js"></script>
    <script src="https://rawgit.com/brandcast/draft-js-built/master/dist/Draft.js"></script>

philipp-spiess · 2017-02-09T13:43:17Z

There seems to be a problem with this patch when selecting text (cmd+a) and using backspace to delete:

removeEntitiesAtEdges.js:74 Uncaught TypeError: Cannot read property 'getCharacterList' of undefined
    at removeForBlock (removeEntitiesAtEdges.js:74)
    at removeEntitiesAtEdges (removeEntitiesAtEdges.js:42)
    at Object.removeRange (DraftModifier.js:94)
    at removeTextWithStrategy (removeTextWithStrategy.js:39)
    at keyCommandPlainBackspace (keyCommandPlainBackspace.js:27)
    at onKeyCommand (editOnKeyDown.js:51)
    at editOnKeyDown (editOnKeyDown.js:142)
    at DraftEditor.react.js:144
    at Object.ReactErrorUtils.invokeGuardedCallback (ReactErrorUtils.js:70)
    at executeDispatch (EventPluginUtils.js:85)
removeForBlock @ removeEntitiesAtEdges.js:74
removeEntitiesAtEdges @ removeEntitiesAtEdges.js:42
removeRange @ DraftModifier.js:94
removeTextWithStrategy @ removeTextWithStrategy.js:39
keyCommandPlainBackspace @ keyCommandPlainBackspace.js:27
onKeyCommand @ editOnKeyDown.js:51
editOnKeyDown @ editOnKeyDown.js:142
(anonymous) @ DraftEditor.react.js:144
ReactErrorUtils.invokeGuardedCallback @ ReactErrorUtils.js:70
executeDispatch @ EventPluginUtils.js:85
executeDispatchesInOrder @ EventPluginUtils.js:108
_EventPluginUtils2.default.executeDispatchesInOrder @ ReactEventRoot.js:92
executeDispatchesAndRelease @ EventPluginHub.js:43
executeDispatchesAndReleaseTopLevel @ EventPluginHub.js:54
forEachAccumulated @ forEachAccumulated.js:24
processEventQueue @ EventPluginHub.js:257
runEventQueueInBatch @ ReactEventEmitterMixin.js:17
handleTopLevel @ ReactEventEmitterMixin.js:28
handleTopLevelImpl @ ReactEventListener.js:72
perform @ Transaction.js:140

acusti · 2017-02-09T14:02:37Z

@philipp-spiess Glad you gave it a try, and thanks for reporting back! Can you share the set up you put together (maybe a small repo, or a fiddle / codepen thing) that led to getting that error after select all + backspace, as well as what browser you were using? And do you get the error with the small demo I made? See http://codepen.io/acusti/pen/RGEJZE?editors=0011

Would love to track down that issue if possible, but I can’t reproduce it in my demo or in the app we built off of the forks I mention in #765 (comment)

philipp-spiess · 2017-02-09T15:03:51Z

@acusti argh never mind. After setting up the fiddle and frustrating why it works there I read your comments again and found out I forgot to add the other patches (react, react-dom and fbjs). :)

Sooo. How about we get someone to merge this and the PR on react? 😎

acusti · 2017-02-10T14:31:15Z

Right on. Let's do it 👍!

rogyvojevic · 2017-02-11T15:39:20Z

Is the fix merged to all the libraries?

acusti · 2017-02-13T14:22:44Z

@rogyvoje Hasn’t been any movement on this that I know of in React or here in Draft.js.

rogyvojevic · 2017-02-14T10:40:42Z

@acusti Well, is there anything that we can do to help them merge faster or something like that? 😕
Because I can really confirm that it is working properly, I have created my own editor, that I can use inside iframe, based on those built libraries, and react is also working correctly outside the iframe 👍

oliver-bauer · 2017-06-03T18:02:50Z

Hey together, is this request integrated anytime soon? I also need to render a draftjs component into an iFrame! It would be awesome, if you could integrate it! Thanks! @spicyj maybe?

charlieclark · 2017-07-10T17:01:21Z

Would love to see this merged in! Any updates?

Drafter500 · 2017-09-21T15:52:18Z

Guys, are there any updates?

sophiebits

Hi – sorry for the very slow response here. Added a few inline comments; if you have time to update and rebase then this would be good for merge. For some of the instanceof checks you may need to work around Flow. Something more like:

if (node.nodeType === 1) {
var element: Element = (node: any);
}

sophiebits · 2017-09-21T18:23:38Z

src/component/handlers/edit/editOnBlur.js

@@ -28,8 +28,12 @@ function editOnBlur(editor: DraftEditor, e: SyntheticEvent): void {
  // issue to be certain, checking whether the active element is `body`
  // to force it when blurring occurs within the window (as opposed to
  // clicking to another tab or window).
-  if (isWebKit && getActiveElement() === document.body) {
-    global.getSelection().removeAllRanges();
+  var doc = e.target && e.target.ownerDocument instanceof Document ?


What's the reason for this check? I'd expect e.target.ownerDocument would always be a document. Also, you need e.target.ownerDocument.nodeType === 9 or else this won't work in multiple realms – exactly the case this is trying to support.

sophiebits · 2017-09-21T18:24:47Z

src/component/selection/findAncestorOffsetKey.js

@@ -20,7 +20,7 @@ var getSelectionOffsetKeyForNode = require('getSelectionOffsetKeyForNode');
 */
 function findAncestorOffsetKey(node: Node): ?string {
  let searchNode = node;
-  while (searchNode && searchNode !== document.documentElement) {
+  while (searchNode && searchNode !== searchNode.ownerDocument.documentElement) {


Maybe just: searchNode.nodeName !== 'HTML'?

sophiebits · 2017-09-21T18:25:19Z

src/component/selection/getDraftEditorSelectionWithNodes.js

    invariant(
-      node instanceof Element && node.getAttribute('data-contents') === 'true',
+      win && node instanceof win.Element && node.getAttribute('data-contents') === 'true',


node.nodeType === 1

@sophiebits To appease Flow, I needed to change it to:

node = node.firstChild; invariant( node && node.nodeType === 1 && typeof node.getAttribute === 'function' && node.getAttribute('data-contents') === 'true', 'Invalid DraftEditorContents structure.', );

Does that seem reasonable to you?

Note that in this case, because of the invariant expression, I can’t really cast node as an Element, at least not in any way that makes much sense.

sophiebits · 2017-09-21T18:25:30Z

src/component/selection/getSelectionOffsetKeyForNode.js

@@ -18,7 +18,8 @@
 * found on the DOM tree of given node.
 */
 function getSelectionOffsetKeyForNode(node: Node): ?string {
-  if (node instanceof Element) {
+  var win = node.ownerDocument.defaultView;
+  if (win && node instanceof win.Element) {


node.nodeType === 1

As above, this needed typeof node.getAttribute === 'function'

Sorry, the above reply is incorrect. Here, the issue is solved by casting node as an Element, as in var element: Element = (node: any);

sophiebits · 2017-09-21T18:26:23Z

src/model/encoding/convertFromHTMLToContentBlocks.js

  if (styleToCheck) {
    currentStyle = currentStyle.add(styleToCheck).toOrderedSet();
-  } else if (node instanceof HTMLElement) {
+  } else if (node instanceof win.HTMLElement) {


node.nodeType === 1

In this case, refining the node type to Element is insufficient, because the style object is a part of the HTMLElement interface. I can make Flow be ok with that with:

const htmlElement: HTMLElement = (node: any);

But seems strictly speaking to be inaccurate?

sophiebits · 2017-09-21T18:26:44Z

src/model/encoding/convertFromHTMLToContentBlocks.js

  invariant(
-    link instanceof HTMLAnchorElement,
+    link instanceof win.HTMLAnchorElement,


link.nodeName === 'A'

sophiebits · 2017-09-21T18:26:54Z

src/model/encoding/convertFromHTMLToContentBlocks.js

  // IMG tags
  if (
    nodeName === 'img' &&
-    node instanceof HTMLImageElement &&
+    node instanceof win.HTMLImageElement &&


node.nodeName === 'IMG'

sophiebits · 2017-09-21T18:26:59Z

src/model/encoding/convertFromHTMLToContentBlocks.js

@@ -459,7 +463,7 @@ function genFragment(

  while (child) {
    if (
-      child instanceof HTMLAnchorElement &&
+      child instanceof win.HTMLAnchorElement &&


sophiebits

^

acusti · 2017-09-22T00:20:16Z

@sophiebits Thanks so much for the review! It's been a while, but if I remember correctly, all the instanceof checks were specifically to appease flow, because checking nodeType didn't seem to be enough. But I will need to refamiliarize myself with the code and verify to see if that's the case (I may misremember, or the core DOM type defs might've changed).

So happy to see this getting picked up! I'll try to carve out some time to revive this work in the next week.

flarnie · 2017-10-15T00:52:38Z

Hi - just came across this, and it looks like we just need a few tweaks to get this ready. I can try to fix it up if I have time, or @acusti if you still have interest.

danwoodbury · 2017-10-23T20:04:41Z

Is there any movement on this? bing able to render draft.js inside an iframe (using https://github.com/ryanseddon/react-frame-component) would be an absolute life saver

acusti · 2017-10-23T20:48:29Z

@danwoodbury It’s being actively worked on (by me)

mhhegazy · 2017-10-23T22:09:54Z

this issue need to be solved so badly
if any thing can I help with, I'll will be more then happy to contribute on this issue

ALEX-TING · 2017-10-27T14:00:42Z

@danwoodbury same boat :)
@acusti @sophiebits @flarnie @devanecondition Thanks all for working on this. Definitely appreciated 💯

acusti · 2017-10-31T14:39:17Z

For anyone out there who has been looking for this functionality (rendering draft.js editors inside an iframe using https://github.com/ryanseddon/react-frame-component or similar), you can try it out by updating the draft-js, react and react-dom dependencies in your package.json to:

    "draft-js": "brandcast/draft-js-built#4cdfd28",
    "react": "brandcast/react-built#a384c20",
    "react-dom": "brandcast/react-dom-built#3804391",

Important note: that particular draft.js build (not this PR) is intended to be used with immutable v4 (which is still only an RC and full of breaking changes). Also, those versions of React are based off of v16.

Need for guard is a result of the fact that the code now gets DOM node’s owner window instead of global window. Previously, in the cases where the DOM node isn’t in a window, the code would run but not do anything. With this change, the function will early return and the rest of the code won’t be run.

acusti · 2018-01-06T22:16:05Z

@sophiebits @flarnie Happy 2018! I merged latest master and dealt with conflicts, then cleaned up some code in the editOn* handlers to make it simpler and more consistent and added a guard (commit message description has details) that failing tests exposed as necessary.

Hoping we can get this rolling again now that we’ve all returned from winter vacation. I believe I’ve addressed all of Sophie’s requested changes and I don’t know of any further work to do. This PR won’t accomplish the goal of making Draft work when rendered into an iframe on its own, because that will require landing facebook/react#9184. But it will make Draft independently compatible to operate across nested browsing contexts (iframes or separate browser windows opened from the parent), cleaning up some code along the way (-9 net change in # of lines).

flarnie · 2018-01-08T00:55:13Z

@acusti Thanks for updating this! Reviewing it now, and Happy New Year to you too! 🎉:)

flarnie · 2018-01-08T01:02:49Z

Since you mentioned the other PR on React, facebook/react#9184 , I looked at that and I think we should figure out whether that will be landed or not first.

I'm really impressed with your ongoing work on both these PRs, and overall on the use case of React in iframes. Thanks for sticking with it. I'm adding it to the React team agenda, hopefully we can get an answer about this soon.

acusti · 2018-01-17T14:26:04Z

@flarnie Thanks for the updates on the React side of things! I wanted to update to say that I realized that there is a valid use case for being able to render a Draft editor, even without the changes in React that this PR partially depends on: you can use Draft to render a readOnly editor in order to preview draft content as HTML into an iframe. Currently, all of the instanceof HTMLElement checks in invariants() that this PR replaces causes draft to throw when the editorState prop gets updated for that <Editor> component. Using the code in this PR makes it work (again, even without the changes in React).

I wanted to call out this use case because wanting to render the HTML of editor content into an iframe to preview it with CSS that shouldn’t apply to the rest of the app is realistic and useful on its own. Rendering an interactable editor still won’t work, of course, because of limitations in React’s SelectEventPlugin and ReactDOMSelection DOM manipulations and calculations.

acusti · 2018-08-03T00:13:41Z

@flarnie The React PR to support iframes for selection event handling and restoration has been merged facebook/react#12037 (comment) 🎉

I see we have 8 conflicts above for us to go through, but I’m hoping this means we can get this merged soon, I know that v0.11.x has been pending for a while. Could this be the kind of thing that could land in the 0.10.x range?

gjulivan · 2018-09-04T05:41:23Z

Hi, how is this issue going on?
I tried using draft-js alpha v 11, but still got problems with linkify when i combine it with mention-plugin.

need a stable version released soon, thanks @acusti , the brandcast branch is useful for now.

my usage is using draft-js in iframe,
and then support editing to pop up as a lightbox to parent's frame (same-domain) using react-portal.

haikyuu · 2018-09-07T08:25:49Z

Thanks for your great work @acusti

I have worked for a while on this issue, and one pattern that i see frequently is accessing the iframe window object. We need to access it in order to get the selection or in order to check for the type of a node instanceof HTMLElement (because it varies depending on the window object)

const domSelection = editorNode.ownerDocument.defaultView.getSelection();

invariant(
- node instanceof Element &&
+ node instanceof defaultView.Element && 
    node.getAttribute('data-contents') === 'true',
  'Invalid DraftEditorContents structure.',
);

We can sometimes access it if we have a DOM node in the scope. But sometimes we can't. For example in component/handlers/edit/commands/keyCommandBackspaceToStartOfLine.js.

We can add an optional prop called windowObject to the Editor component, and pass that wherever it's needed. I've put it in the global object for convenience (to move quickly) but we should find be a better way to access it in various places.

marchaos · 2018-11-29T10:27:02Z

Is there a way that we can push this issue forward? Is there an area where help is needed as it seems to have gone a little dormant.

haikyuu · 2018-11-29T12:56:27Z

@marchaos Work on this feature is continued in this PR #1938

marchaos · 2018-11-30T16:45:11Z

Thanks @haikyuu. I've got that branch working with popout windows 👍

mrkev · 2019-11-20T18:54:18Z

Follow up: #1877
Fixed in: #1938

facebook-github-bot added GH Review: review-needed CLA Signed labels Nov 5, 2016

This was referenced Nov 5, 2016

DraftJS is not actually stateless #527

Open

Support iframes (nested browsing contexts) in selection event handling (stale version) facebook/react#7936

Closed

acusti force-pushed the iframe-compatibility branch 2 times, most recently from ca12190 to cac9f0a Compare December 7, 2016 03:49

acusti force-pushed the iframe-compatibility branch from cac9f0a to c8760c4 Compare April 9, 2017 23:17

sophiebits removed the GH Review: review-needed label Aug 24, 2017

sophiebits reviewed Sep 21, 2017

View reviewed changes

sophiebits suggested changes Sep 21, 2017

View reviewed changes

flarnie self-requested a review October 15, 2017 00:54

devanecondition and others added 3 commits October 23, 2017 18:01

Use ownerDocument for doc, defaultView for window

fc45900

Use ownerDocument with getActiveElement

e68b034

Add checks and guards for nullable and unknown values

be8f251

acusti force-pushed the iframe-compatibility branch 2 times, most recently from 27564fd to e41f4ee Compare October 30, 2017 15:10

acusti added 2 commits October 30, 2017 08:11

Replace instanceof checks with nodeType checks

dcd41c6

Linting

99c5348

acusti force-pushed the iframe-compatibility branch from e41f4ee to 99c5348 Compare October 30, 2017 15:11

acusti added 2 commits October 30, 2017 08:22

Merge remote-tracking branch 'upstream/master' into iframe-compatibility

a440f39

Linting

db54431

acusti added 2 commits January 6, 2018 10:31

Merge branch 'master' into iframe-compatibility

6587984

Simplify editOn* helpers and improve consistency

197d481

acusti force-pushed the iframe-compatibility branch from c441b6a to 197d481 Compare January 6, 2018 21:59

acusti added 2 commits January 6, 2018 14:09

Apply DrafteEditorBlock updates to exploration

34d04c4

Minivera mentioned this pull request Feb 6, 2018

Draft.js + Meteor + iframe causes node instanceof Element to return false #1640

Closed

flarnie mentioned this pull request Feb 27, 2018

element.getComputedStyle returns null in Firefox iFrame with display:none #1669

Open

claudiopro self-assigned this Sep 4, 2018

haikyuu mentioned this pull request Sep 21, 2018

Support rendering Draft-js into iframe #1877

Closed

mrkev closed this Nov 20, 2019

Support rendering Draft.js into iframes (nested browsing contexts) #765

Support rendering Draft.js into iframes (nested browsing contexts) #765

Conversation

acusti commented Nov 5, 2016 • edited Loading

Summary

Test Plan

Try it out via npm

Try it out in the browser

acusti commented Dec 7, 2016

npm / yarn

in the browser

philipp-spiess commented Feb 9, 2017

acusti commented Feb 9, 2017 • edited Loading

philipp-spiess commented Feb 9, 2017 • edited Loading

acusti commented Feb 10, 2017 • edited Loading

rogyvojevic commented Feb 11, 2017

acusti commented Feb 13, 2017

rogyvojevic commented Feb 14, 2017 • edited Loading

oliver-bauer commented Jun 3, 2017 • edited Loading

charlieclark commented Jul 10, 2017

Drafter500 commented Sep 21, 2017 • edited Loading

sophiebits left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

acusti Oct 23, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sophiebits left a comment

Choose a reason for hiding this comment

acusti commented Sep 22, 2017 • edited Loading

flarnie commented Oct 15, 2017

danwoodbury commented Oct 23, 2017

acusti commented Oct 23, 2017

mhhegazy commented Oct 23, 2017

ALEX-TING commented Oct 27, 2017

acusti commented Oct 31, 2017 • edited Loading

acusti commented Jan 6, 2018 • edited Loading

flarnie commented Jan 8, 2018

flarnie commented Jan 8, 2018

acusti commented Jan 17, 2018

acusti commented Aug 3, 2018

gjulivan commented Sep 4, 2018 • edited Loading

haikyuu commented Sep 7, 2018 • edited Loading

marchaos commented Nov 29, 2018

haikyuu commented Nov 29, 2018

marchaos commented Nov 30, 2018

mrkev commented Nov 20, 2019

acusti commented Nov 5, 2016 •

edited

Loading

acusti commented Feb 9, 2017 •

edited

Loading

philipp-spiess commented Feb 9, 2017 •

edited

Loading

acusti commented Feb 10, 2017 •

edited

Loading

rogyvojevic commented Feb 14, 2017 •

edited

Loading

oliver-bauer commented Jun 3, 2017 •

edited

Loading

Drafter500 commented Sep 21, 2017 •

edited

Loading

acusti Oct 23, 2017 •

edited

Loading

acusti commented Sep 22, 2017 •

edited

Loading

acusti commented Oct 31, 2017 •

edited

Loading

acusti commented Jan 6, 2018 •

edited

Loading

gjulivan commented Sep 4, 2018 •

edited

Loading

haikyuu commented Sep 7, 2018 •

edited

Loading