This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
Add convertToHTML example for version 0.9.1 #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiasandersen
changed the title
|
Thanks for fixing this! 😄 |
|
Great! There seems to be a bit of a confusion/worry, both here on the issue tracker and in the slack channel, about these changes. I think it would be a good idea to clarify what's going on. Some questions I've seen come up are e.g:
I can't answer all of these questions (e.g. I don't know when the next release will be). And I'm not really sure where this info would make sense either. In the docs somewhere? In the README? |
|
Thanks @tobiasandersen - just made an issue for answering some of those questions. #839 |
ouchxp
pushed a commit
to ouchxp/draft-js
that referenced
this pull request
Apr 7, 2017
* Add convertFromHTML example for 0.9.1 * Update docs with convertFromHTML example * Remove image from convertFromHTML example in 0-9-1 * Update 0.9.1 convertFromHTML example to use the old Entity API * Fix link to convertToHTML example in docs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a convertToHTML example for version 0.9.1 (only present for 0.10.0 currently). In it, I've removed everything that has to do with images (since that's not supported in 0.9.1), and updated the link decorator to use the old API for entities. Note that this example won't work on master (because of the change to entities). Maybe we should add some information about this somewhere?
This should also fix the broken link in the bottom of this document: https://github.com/facebook/draft-js/blob/master/docs/APIReference-Data-Conversion.md#convertfromhtml. It's currently pointing to a file that doesn't exist (just noticed this now).
I've also updated that document to use the API for version 0.9.1, since it was creating confusion (see #809). Let me know if this isn't correct (or just remove it)!