This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
fix contentEditable warning #98
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -262,6 +262,7 @@ class DraftEditor | |||
| ref="editor" | |||
| role={readOnly ? null : (this.props.role || 'textbox')} | |||
| spellCheck={allowSpellCheck && this.props.spellCheck} | |||
| suppressContentEditableWarning={!readOnly} | |||
There was a problem hiding this comment.
@hellendag Of course it can. Fixed.
|
We have the same warning even after using this new attribute. Are we missing something? We use React 14.0. Thanks! |
|
@adcoolguy: The Also, you won't have to place the prop on your |
|
I actually ended up getting this as part of #179. Thanks for sending this in though! |
flarnie
added a commit
to flarnie/draft-js
that referenced
this pull request
Sep 20, 2016
The issue with 'React ContentEditable Warning' was resolved when React added the 'suppressContentEditableWarning' option[1] and then we used it in Draft.js[2]. This doesn't need to be in the docs any more. [1]: facebook/react#6112 [2]: facebookarchive#98
ouchxp
pushed a commit
to ouchxp/draft-js
that referenced
this pull request
Apr 7, 2017
The issue with 'React ContentEditable Warning' was resolved when React added the 'suppressContentEditableWarning' option[1] and then we used it in Draft.js[2]. This doesn't need to be in the docs any more. [1]: facebook/react#6112 [2]: facebookarchive#98
midas19910709
added a commit
to midas19910709/draft-js
that referenced
this pull request
Mar 30, 2022
The issue with 'React ContentEditable Warning' was resolved when React added the 'suppressContentEditableWarning' option[1] and then we used it in Draft.js[2]. This doesn't need to be in the docs any more. [1]: facebook/react#6112 [2]: facebookarchive/draft-js#98
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #53. The issue has been fixed in the React repo: facebook/react#6112 .