Skip to content
This repository has been archived by the owner on Nov 2, 2019. It is now read-only.

Resolve Carthage Issues with Xcode 10 #282

Merged
merged 4 commits into from
Oct 18, 2018
Merged

Resolve Carthage Issues with Xcode 10 #282

merged 4 commits into from
Oct 18, 2018

Conversation

codytwinton
Copy link
Contributor

Facebook Swift SDK Pull Request

Checklist

  • I've read the Contributing Guidelines and the Code of Conduct
  • I've completed the Contributor License Agreement
  • I've ensured that all existing tests pass and added tests (when/where necessary)
  • I've ensured that my code lints properly: (swiftlint && swiftlint autocorrect --format)
  • I've updated the documentation (when/where necessary) and Changelog (when/where necessary)
  • I've added the proper label to this pull request (e.g. bug for bug fixes)

Pull Request Details

Resolved issues with Carthage for Xcode 10

@codytwinton codytwinton added the bug Something is broken or being fixed label Oct 18, 2018
@codytwinton codytwinton self-assigned this Oct 18, 2018
@facebook-github-bot facebook-github-bot added the CLA Signed The Facebook CLA has been signed label Oct 18, 2018
lostatseajoshua
lostatseajoshua approved these changes Oct 18, 2018
View reviewed changes
Copy link
Contributor

@lostatseajoshua lostatseajoshua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this working! 👍

@codytwinton
Copy link
Contributor Author

This should resolve #246

@codytwinton codytwinton merged commit e8ed454 into master Oct 18, 2018
@codytwinton codytwinton deleted the resolve-carthage-issues branch October 18, 2018 17:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lostatseajoshua lostatseajoshua lostatseajoshua approved these changes

@nlutsenko nlutsenko Awaiting requested review from nlutsenko

@AndrewSB AndrewSB Awaiting requested review from AndrewSB

Assignees

@codytwinton codytwinton

Labels
bug Something is broken or being fixed CLA Signed The Facebook CLA has been signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codytwinton @lostatseajoshua @facebook-github-bot