Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

chore: Add PHP built in for MacOS #189

Merged
merged 5 commits into from
May 24, 2022
Merged

Conversation

eduardocesb
Copy link
Contributor

This PR adds PHP built-in for MacOS App versions.

Apple removed the PHP installed by default on MacOS Monterey and with that, the app cannot find PHP and cannot preview the Article, leaving a loading icon forever.

So now, I added the version 7.4.29 of the PHP built-in for the MacOS systems.

To test the PR you can run the build command and test the App in a MacOS Monterey. As soon as you open the tool you should see the Preview tab showing the message "Open an article..." instead of just seeing the loading icon staying there forever.

@eduardocesb eduardocesb requested a review from nataliemt April 27, 2022 18:03
@eduardocesb eduardocesb self-assigned this Apr 27, 2022
@eduardocesb eduardocesb requested a review from diegoquinteiro May 9, 2022 14:55
@eduardocesb eduardocesb marked this pull request as draft May 9, 2022 14:55
@eduardocesb eduardocesb marked this pull request as ready for review May 16, 2022 13:43
@nataliemt nataliemt merged commit 2a150b8 into main May 24, 2022
@diegoquinteiro diegoquinteiro deleted the chore/add-php-built-in-for-macos branch May 30, 2022 12:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants