This repository has been archived by the owner on Nov 28, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 270
Leaving comment to reveal parsing error in configuration file #188
Comments
jeffreyleeon
added a commit
to jeffreyleeon/mention-bot
that referenced
this issue
Nov 27, 2016
jeffreyleeon
added a commit
to jeffreyleeon/mention-bot
that referenced
this issue
Nov 27, 2016
jeffreyleeon
added a commit
to jeffreyleeon/mention-bot
that referenced
this issue
Nov 27, 2016
vjeux
pushed a commit
that referenced
this issue
Nov 27, 2016
I like #188, but still, we don't provide a specific error message and where the error is. Should we consider
|
Sure! We can try to improve the catch and give a more specific error message. |
jeffreyleeon
added a commit
to jeffreyleeon/mention-bot
that referenced
this issue
Nov 28, 2016
jeffreyleeon
added a commit
to jeffreyleeon/mention-bot
that referenced
this issue
Nov 28, 2016
jeffreyleeon
added a commit
to jeffreyleeon/mention-bot
that referenced
this issue
Nov 29, 2016
vjeux
pushed a commit
that referenced
this issue
Nov 29, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
getRepoConfig function throughs error when .mention-bot is an invalid JSON.
Better to notify and reveal the parsing error by leaving comments when a pr is opened.
The text was updated successfully, but these errors were encountered: