This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
PP0038 used multiple times with different meanings #2439
Assignees
Labels
Comments
|
I'll allocate a new one for the condition in __assume and add it to the wiki. |
facebook-github-bot
pushed a commit
that referenced
this issue
Aug 22, 2018
Summary: Fixes #2419 #2386 #2439 #2447 #2432 #2437 #2442 * Fix havoced binding not in optimized function * Allow arrays with widened numeric properties to update index properties * Fix nested for statement bailout with nested for-in * Don’t record modified bindings for immutable bindings when havocing Reviewed By: trueadm, sebmarkbage Differential Revision: D9456957 fbshipit-source-id: f266b8cc73012b9c721f0f9eebd48347bf0e37ae
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
PP0038 is issued here, and has a matching wiki page: https://github.com/facebook/prepack/wiki/PP0038
https://github.com/facebook/prepack/blob/7157849a44b5136362551b02140c3e4653c980fa/src/methods/properties.js#L1002
However, PP0038 is also used in two more totally separate context, which is wrong. Both of the following two contexts should get unique error numbers and their own wiki pages:
https://github.com/facebook/prepack/blob/3e8c638071ca0bd429b4a45ebf464276dacd85c4/src/intrinsics/prepack/global.js#L338
https://github.com/facebook/prepack/blob/9f62eeabc688741d1df0aab3f5cac941ad533604/src/serializer/ResidualHeapSerializer.js#L1272
The text was updated successfully, but these errors were encountered: