Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #303

Merged
merged 29 commits into from
Feb 14, 2022
Merged

Fix #303

merged 29 commits into from
Feb 14, 2022

Conversation

jeffedwards
Copy link
Contributor

Project Robyn

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • API change with a documentation update
  • Additional test coverage
  • Code cleanup or just keeping up with the latest Rustc nightly

How Has This Been Tested?

Checklist:

  • Fork the repo and create your branch from master.
  • If you've added code that should be tested, add tests.
  • If you've changed APIs, update the documentation.
  • Ensure the test suite passes.
  • Make sure your code lints.

nuochen and others added 29 commits October 12, 2021 15:31
@nuochen
initial commit to branch
4107b3b
@nuochen
added pypref
4436262
@nuochen
hyperparam and split
ba16c82
@adullam
Added - calibration mape in mmm function
57f9049
@stephensheron
adding intital Dockerfile, requirements.txt, and get_python_details.p…
75333bc 
…y for testing
@nuochen
updated start ng loop
8920d2e
@nuochen
updated start ng loop
d862adf
@nuochen
updated get hyperparameters
1570a47
@jeffedwards
Committing changes made by Thami
28df779
@jeffedwards
Commented out blocks of code that were causing errors
d1e7011
@jeffedwards
Formatting adjustments
1d2a1d2
@jeffedwards
Merge pull request #234 from facebookexperimental/fix_jde_20211209
c33da65 
Fix jde 20211209
@jeffedwards
Added a couple file to run the code with actual data
a2b5520
@jeffedwards
Merge pull request #235 from facebookexperimental/jde_20211209_python…
ceebcfe 
…_files

Added a couple file to run the code with actual data
@jeffedwards
Merge branch 'main' of https://github.com/facebookexperimental/Robyn …
1c0a80b 
…into jde_20211209_general_and_troubleshoot
@jeffedwards
Updates from today
685ca8d
@jeffedwards
Merge pull request #236 from facebookexperimental/jde_20211209_genera…
5e8793b 
…l_and_troubleshoot

Jde 20211209 general and troubleshoot
@jeffedwards
quick updates
3fc5a3d
@jeffedwards
Merge pull request #237 from facebookexperimental/jde_20211209_genera…
ea268a2 
…l_and_troubleshoot

quick updates
@jeffedwards
quick updates
53b210a
@jeffedwards
Merge pull request #238 from facebookexperimental/jde_20211209_genera…
fb9ca98 
…l_and_troubleshoot

quick updates
@jeffedwards
Updated gitignore to ignore files that are causing conflicts and shou…
e8e69fb 
…ld be ignored.
@jeffedwards
Updated gitignore to ignore files that are causing conflicts and shou…
d90698e 
…ld be ignored.
@jeffedwards
Merge branch 'main' of https://github.com/facebookexperimental/Robyn …
35e05af 
…into fix

� Conflicts:
�	util/demo.py
�	util/robyn.py
@jeffedwards
Updated branch with master and then re-added some files back
48032fc
@jeffedwards
Updated for fix object to work. Updating check conditions to work
4d1df55
@jeffedwards
Merge pull request #254 from facebookexperimental/fix_jde_20211228
1de9be5 
Updated for fix object to work. Updating check conditions to work
@nuochen
updated final outputs
053da62
@nuochen
added documentations
6cd2ee0
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 14, 2022
@jeffedwards jeffedwards merged commit 4b187ce into main Feb 14, 2022
@jeffedwards jeffedwards deleted the fix branch February 14, 2022 14:44
@jeffedwards jeffedwards mentioned this pull request Feb 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jeffedwards @facebook-github-bot @nuochen @adullam @stephensheron