Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: crashed cut() when monthly data #868

Merged
merged 2 commits into from
Nov 24, 2023
Merged

fix: crashed cut() when monthly data #868

merged 2 commits into from
Nov 24, 2023

Conversation

laresbernardo
Copy link
Collaborator

Issue with holidays data when monthly granularity fixed.

Error in mutate(., ds = cut(.data$ds, intervalType)) : 
  ℹ In argument: `ds = cut(.data$ds, intervalType)`.
Caused by error in `cut.default()`:
! 'x' must be numeric

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 23, 2023
gufengzhou
gufengzhou approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@gufengzhou gufengzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gufengzhou gufengzhou merged commit 249cac6 into facebookexperimental:main Nov 24, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gufengzhou gufengzhou gufengzhou approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laresbernardo @gufengzhou @facebook-github-bot