Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: intercept param in outputs + ts_validation plot for convergence #917

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

laresbernardo
Copy link
Collaborator

fix: intercept input not being stored (thus not exported in JSON file

fix: add ts_validation plot to all_plots and export regardless of ts_validation param for convergence viz

@laresbernardo laresbernardo self-assigned this Feb 5, 2024
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 5, 2024
@laresbernardo
Copy link
Collaborator Author

Example of (dummy) 1 trial and ts_validation = FALSE output generated
da68b514-43a0-47ed-aae8-4f836574c6c0

Copy link
Contributor

@gufengzhou gufengzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@laresbernardo laresbernardo merged commit 1677723 into main Feb 6, 2024
2 checks passed
@laresbernardo laresbernardo deleted the blbranch branch February 6, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants