Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: clarify objective_weights order #929

Merged
merged 2 commits into from
Feb 21, 2024
Merged

docs: clarify objective_weights order #929

merged 2 commits into from
Feb 21, 2024

Conversation

laresbernardo
Copy link
Collaborator

No description provided.

@laresbernardo laresbernardo added the documentation Improvements or additions to documentation label Feb 20, 2024
@laresbernardo laresbernardo self-assigned this Feb 20, 2024
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 20, 2024
gufengzhou
gufengzhou reviewed Feb 21, 2024
View reviewed changes
Copy link
Contributor

@gufengzhou gufengzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bit confusing to have example of c(2,1) for only two objs, but there're 3 in total. We should explain when not calibrating, only RMSE and Rssd, then c(2,1) gives double weight to the first etc. Just more clarity please

@laresbernardo
Copy link
Collaborator Author

Alright, clarified.

gufengzhou
gufengzhou approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@gufengzhou gufengzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@laresbernardo laresbernardo merged commit c9d2adf into main Feb 21, 2024
2 checks passed
@laresbernardo laresbernardo deleted the blbranch branch February 21, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gufengzhou gufengzhou gufengzhou approved these changes

Assignees

@laresbernardo laresbernardo

Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laresbernardo @gufengzhou @facebook-github-bot