-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rust/shed/hostname: rename hostname dependency to unbreak doctests #15
Closed
lukaspiatkowski
wants to merge
1
commit into
facebookexperimental:master
from
lukaspiatkowski:export-D24390815
Closed
rust/shed/hostname: rename hostname dependency to unbreak doctests #15
lukaspiatkowski
wants to merge
1
commit into
facebookexperimental:master
from
lukaspiatkowski:export-D24390815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
labels
Oct 19, 2020
This pull request was exported from Phabricator. Differential Revision: D24390815 |
Summary: With the update from rustc 1.44 to 1.47 the doctests started to break when building a crate that depends on a different crate of the same name, see this: rust-lang/cargo#6819 This diff also removes the TravisCI build as it was broken and unused for some time. Differential Revision: D24390815 fbshipit-source-id: 8e2047715a83b50c3de4f8c74f0565799185f2ea
lukaspiatkowski
force-pushed
the
export-D24390815
branch
from
October 19, 2020 11:31
1064ed3
to
7a36595
Compare
This pull request was exported from Phabricator. Differential Revision: D24390815 |
facebook-github-bot
pushed a commit
to facebookarchive/fbzmq
that referenced
this pull request
Oct 19, 2020
Summary: Pull Request resolved: facebookexperimental/rust-shed#15 With the update from rustc 1.44 to 1.47 the doctests started to break when building a crate that depends on a different crate of the same name, see this: rust-lang/cargo#6819 This diff also removes the TravisCI build as it was broken and unused for some time. Reviewed By: krallin Differential Revision: D24390815 fbshipit-source-id: fa9c78ef394640afbf8c419f8276bbf339960406
facebook-github-bot
pushed a commit
to rsocket/rsocket-cpp
that referenced
this pull request
Oct 19, 2020
Summary: Pull Request resolved: facebookexperimental/rust-shed#15 With the update from rustc 1.44 to 1.47 the doctests started to break when building a crate that depends on a different crate of the same name, see this: rust-lang/cargo#6819 This diff also removes the TravisCI build as it was broken and unused for some time. Reviewed By: krallin Differential Revision: D24390815 fbshipit-source-id: fa9c78ef394640afbf8c419f8276bbf339960406
facebook-github-bot
pushed a commit
to facebookincubator/below
that referenced
this pull request
Oct 19, 2020
Summary: Pull Request resolved: facebookexperimental/rust-shed#15 With the update from rustc 1.44 to 1.47 the doctests started to break when building a crate that depends on a different crate of the same name, see this: rust-lang/cargo#6819 This diff also removes the TravisCI build as it was broken and unused for some time. Reviewed By: krallin Differential Revision: D24390815 fbshipit-source-id: fa9c78ef394640afbf8c419f8276bbf339960406
facebook-github-bot
pushed a commit
to facebook/sapling
that referenced
this pull request
Oct 19, 2020
Summary: Pull Request resolved: facebookexperimental/rust-shed#15 With the update from rustc 1.44 to 1.47 the doctests started to break when building a crate that depends on a different crate of the same name, see this: rust-lang/cargo#6819 This diff also removes the TravisCI build as it was broken and unused for some time. Reviewed By: krallin Differential Revision: D24390815 fbshipit-source-id: fa9c78ef394640afbf8c419f8276bbf339960406
facebook-github-bot
pushed a commit
to facebookarchive/bistro
that referenced
this pull request
Oct 19, 2020
Summary: Pull Request resolved: facebookexperimental/rust-shed#15 With the update from rustc 1.44 to 1.47 the doctests started to break when building a crate that depends on a different crate of the same name, see this: rust-lang/cargo#6819 This diff also removes the TravisCI build as it was broken and unused for some time. Reviewed By: krallin Differential Revision: D24390815 fbshipit-source-id: fa9c78ef394640afbf8c419f8276bbf339960406
facebook-github-bot
pushed a commit
to facebookincubator/fizz
that referenced
this pull request
Oct 19, 2020
Summary: Pull Request resolved: facebookexperimental/rust-shed#15 With the update from rustc 1.44 to 1.47 the doctests started to break when building a crate that depends on a different crate of the same name, see this: rust-lang/cargo#6819 This diff also removes the TravisCI build as it was broken and unused for some time. Reviewed By: krallin Differential Revision: D24390815 fbshipit-source-id: fa9c78ef394640afbf8c419f8276bbf339960406
facebook-github-bot
pushed a commit
to facebookincubator/reindeer
that referenced
this pull request
Oct 19, 2020
Summary: Pull Request resolved: facebookexperimental/rust-shed#15 With the update from rustc 1.44 to 1.47 the doctests started to break when building a crate that depends on a different crate of the same name, see this: rust-lang/cargo#6819 This diff also removes the TravisCI build as it was broken and unused for some time. Reviewed By: krallin Differential Revision: D24390815 fbshipit-source-id: fa9c78ef394640afbf8c419f8276bbf339960406
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 19, 2020
Summary: Pull Request resolved: #15 With the update from rustc 1.44 to 1.47 the doctests started to break when building a crate that depends on a different crate of the same name, see this: rust-lang/cargo#6819 This diff also removes the TravisCI build as it was broken and unused for some time. Reviewed By: krallin Differential Revision: D24390815 fbshipit-source-id: fa9c78ef394640afbf8c419f8276bbf339960406
facebook-github-bot
pushed a commit
to facebook/folly
that referenced
this pull request
Oct 19, 2020
Summary: Pull Request resolved: facebookexperimental/rust-shed#15 With the update from rustc 1.44 to 1.47 the doctests started to break when building a crate that depends on a different crate of the same name, see this: rust-lang/cargo#6819 This diff also removes the TravisCI build as it was broken and unused for some time. Reviewed By: krallin Differential Revision: D24390815 fbshipit-source-id: fa9c78ef394640afbf8c419f8276bbf339960406
facebook-github-bot
pushed a commit
to facebook/fb303
that referenced
this pull request
Oct 19, 2020
Summary: Pull Request resolved: facebookexperimental/rust-shed#15 With the update from rustc 1.44 to 1.47 the doctests started to break when building a crate that depends on a different crate of the same name, see this: rust-lang/cargo#6819 This diff also removes the TravisCI build as it was broken and unused for some time. Reviewed By: krallin Differential Revision: D24390815 fbshipit-source-id: fa9c78ef394640afbf8c419f8276bbf339960406
facebook-github-bot
pushed a commit
to facebook/proxygen
that referenced
this pull request
Oct 19, 2020
Summary: Pull Request resolved: facebookexperimental/rust-shed#15 With the update from rustc 1.44 to 1.47 the doctests started to break when building a crate that depends on a different crate of the same name, see this: rust-lang/cargo#6819 This diff also removes the TravisCI build as it was broken and unused for some time. Reviewed By: krallin Differential Revision: D24390815 fbshipit-source-id: fa9c78ef394640afbf8c419f8276bbf339960406
facebook-github-bot
pushed a commit
to facebook/fboss
that referenced
this pull request
Oct 19, 2020
Summary: Pull Request resolved: facebookexperimental/rust-shed#15 With the update from rustc 1.44 to 1.47 the doctests started to break when building a crate that depends on a different crate of the same name, see this: rust-lang/cargo#6819 This diff also removes the TravisCI build as it was broken and unused for some time. Reviewed By: krallin Differential Revision: D24390815 fbshipit-source-id: fa9c78ef394640afbf8c419f8276bbf339960406
facebook-github-bot
pushed a commit
to facebookincubator/katran
that referenced
this pull request
Oct 19, 2020
Summary: Pull Request resolved: facebookexperimental/rust-shed#15 With the update from rustc 1.44 to 1.47 the doctests started to break when building a crate that depends on a different crate of the same name, see this: rust-lang/cargo#6819 This diff also removes the TravisCI build as it was broken and unused for some time. Reviewed By: krallin Differential Revision: D24390815 fbshipit-source-id: fa9c78ef394640afbf8c419f8276bbf339960406
facebook-github-bot
pushed a commit
to facebook/fbthrift
that referenced
this pull request
Oct 19, 2020
Summary: Pull Request resolved: facebookexperimental/rust-shed#15 With the update from rustc 1.44 to 1.47 the doctests started to break when building a crate that depends on a different crate of the same name, see this: rust-lang/cargo#6819 This diff also removes the TravisCI build as it was broken and unused for some time. Reviewed By: krallin Differential Revision: D24390815 fbshipit-source-id: fa9c78ef394640afbf8c419f8276bbf339960406
facebook-github-bot
pushed a commit
to facebook/wangle
that referenced
this pull request
Oct 19, 2020
Summary: Pull Request resolved: facebookexperimental/rust-shed#15 With the update from rustc 1.44 to 1.47 the doctests started to break when building a crate that depends on a different crate of the same name, see this: rust-lang/cargo#6819 This diff also removes the TravisCI build as it was broken and unused for some time. Reviewed By: krallin Differential Revision: D24390815 fbshipit-source-id: fa9c78ef394640afbf8c419f8276bbf339960406
facebook-github-bot
pushed a commit
to facebookarchive/fbmeshd
that referenced
this pull request
Oct 19, 2020
Summary: Pull Request resolved: facebookexperimental/rust-shed#15 With the update from rustc 1.44 to 1.47 the doctests started to break when building a crate that depends on a different crate of the same name, see this: rust-lang/cargo#6819 This diff also removes the TravisCI build as it was broken and unused for some time. Reviewed By: krallin Differential Revision: D24390815 fbshipit-source-id: fa9c78ef394640afbf8c419f8276bbf339960406
facebook-github-bot
pushed a commit
to facebook/watchman
that referenced
this pull request
Oct 19, 2020
Summary: Pull Request resolved: facebookexperimental/rust-shed#15 With the update from rustc 1.44 to 1.47 the doctests started to break when building a crate that depends on a different crate of the same name, see this: rust-lang/cargo#6819 This diff also removes the TravisCI build as it was broken and unused for some time. Reviewed By: krallin Differential Revision: D24390815 fbshipit-source-id: fa9c78ef394640afbf8c419f8276bbf339960406
facebook-github-bot
pushed a commit
to facebook/openr
that referenced
this pull request
Oct 19, 2020
Summary: Pull Request resolved: facebookexperimental/rust-shed#15 With the update from rustc 1.44 to 1.47 the doctests started to break when building a crate that depends on a different crate of the same name, see this: rust-lang/cargo#6819 This diff also removes the TravisCI build as it was broken and unused for some time. Reviewed By: krallin Differential Revision: D24390815 fbshipit-source-id: fa9c78ef394640afbf8c419f8276bbf339960406
facebook-github-bot
pushed a commit
to facebookarchive/LogDevice
that referenced
this pull request
Oct 19, 2020
Summary: Pull Request resolved: facebookexperimental/rust-shed#15 With the update from rustc 1.44 to 1.47 the doctests started to break when building a crate that depends on a different crate of the same name, see this: rust-lang/cargo#6819 This diff also removes the TravisCI build as it was broken and unused for some time. Reviewed By: krallin Differential Revision: D24390815 fbshipit-source-id: fa9c78ef394640afbf8c419f8276bbf339960406
lukaspiatkowski
added a commit
to lukaspiatkowski/rust-shed
that referenced
this pull request
Oct 21, 2020
…acebookexperimental#15) Summary: Pull Request resolved: facebookexperimental#15 With the update from rustc 1.44 to 1.47 the doctests started to break when building a crate that depends on a different crate of the same name, see this: rust-lang/cargo#6819 This diff also removes the TravisCI build as it was broken and unused for some time. Reviewed By: krallin Differential Revision: D24390815 fbshipit-source-id: fa9c78ef394640afbf8c419f8276bbf339960406
dotconnor
pushed a commit
to 5448C8/folly
that referenced
this pull request
Mar 19, 2021
…acebook#15) Summary: Pull Request resolved: facebookexperimental/rust-shed#15 With the update from rustc 1.44 to 1.47 the doctests started to break when building a crate that depends on a different crate of the same name, see this: rust-lang/cargo#6819 This diff also removes the TravisCI build as it was broken and unused for some time. Reviewed By: krallin Differential Revision: D24390815 fbshipit-source-id: fa9c78ef394640afbf8c419f8276bbf339960406
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: With the update from rustc 1.44 to 1.47 the doctests started to break when building a crate that depends on a different crate of the same name, see this: rust-lang/cargo#6819
Differential Revision: D24390815