allow type promotions from bool if common type is non-bool #985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D52770344 |
bradleyhd
added a commit
to bradleyhd/AITemplate
that referenced
this pull request
Jan 30, 2024
…ncubator#985) Summary: for mixed elementwise ops, allow bools to be cast to common dtype. this behavior mimics the behavior of PyTorch when doing things like multiplying a float16 tensor by a bool tensor (results in a float16 tensor). Differential Revision: D52770344
bradleyhd
added a commit
to bradleyhd/AITemplate
that referenced
this pull request
Jan 30, 2024
…ncubator#985) Summary: for mixed elementwise ops, allow bools to be cast to common dtype. this behavior mimics the behavior of PyTorch when doing things like multiplying a float16 tensor by a bool tensor (results in a float16 tensor). Differential Revision: D52770344
bradleyhd
force-pushed
the
export-D52770344
branch
from
f81a780 to
2d0f1f2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52770344 |
…ncubator#985) Summary: for mixed elementwise ops, allow bools to be cast to common dtype. this behavior mimics the behavior of PyTorch when doing things like multiplying a float16 tensor by a bool tensor (results in a float16 tensor). Differential Revision: D52770344
bradleyhd
force-pushed
the
export-D52770344
branch
from
2d0f1f2 to
5de9db1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52770344 |
khabinov
approved these changes
Jan 30, 2024
bradleyhd
added a commit
to bradleyhd/AITemplate
that referenced
this pull request
Jan 30, 2024
…ncubator#985) Summary: for mixed elementwise ops, allow bools to be cast to common dtype. this behavior mimics the behavior of PyTorch when doing things like multiplying a float16 tensor by a bool tensor (results in a float16 tensor). Reviewed By: khabinov Differential Revision: D52770344
bradleyhd
added a commit
to bradleyhd/AITemplate
that referenced
this pull request
Jan 30, 2024
…ncubator#985) Summary: for mixed elementwise ops, allow bools to be cast to common dtype. this behavior mimics the behavior of PyTorch when doing things like multiplying a float16 tensor by a bool tensor (results in a float16 tensor). Reviewed By: khabinov Differential Revision: D52770344
bradleyhd
added a commit
to bradleyhd/AITemplate
that referenced
this pull request
Jan 30, 2024
…ncubator#985) Summary: for mixed elementwise ops, allow bools to be cast to common dtype. this behavior mimics the behavior of PyTorch when doing things like multiplying a float16 tensor by a bool tensor (results in a float16 tensor). Reviewed By: khabinov Differential Revision: D52770344
bradleyhd
added a commit
to bradleyhd/AITemplate
that referenced
this pull request
Jan 30, 2024
…ncubator#985) Summary: for mixed elementwise ops, allow bools to be cast to common dtype. this behavior mimics the behavior of PyTorch when doing things like multiplying a float16 tensor by a bool tensor (results in a float16 tensor). Reviewed By: khabinov Differential Revision: D52770344
|
This pull request has been merged in 54a3adc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: for mixed elementwise ops, allow bools to be cast to common dtype. this behavior mimics the behavior of PyTorch when doing things like multiplying a float16 tensor by a bool tensor (results in a float16 tensor).
Differential Revision: D52770344