-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerize FBX2glTF #184
Merged
zellski
merged 7 commits into
facebookincubator:master
from
FreakTheMighty:feature/docker
May 8, 2019
Merged
Dockerize FBX2glTF #184
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
ff17f4b
Added dockerfile and docker-compose
FreakTheMighty 54e796a
Pulling fbx libraries with git lfs
FreakTheMighty 05ee761
Removed unnecessary line
FreakTheMighty 7fb7c0a
Added comment
FreakTheMighty 8ca855d
Removing git lfs, it causes problems in managed build environments su…
FreakTheMighty 225d076
The Dockerfile can tell Conan exactly what its system is.
zellski 0987bb5
Merge pull request #1 from zellski/FreakTheMighty-feature/docker
FreakTheMighty File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
.dockerignore | ||
Dockerfile | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
FROM ubuntu:16.04 | ||
|
||
RUN apt-get update && \ | ||
apt-get install -y software-properties-common && \ | ||
add-apt-repository ppa:jonathonf/python-3.6 && \ | ||
add-apt-repository ppa:git-core/ppa && \ | ||
apt-get update && \ | ||
apt-get install -y python3.6 curl build-essential cmake libxml2-dev zlib1g-dev git && \ | ||
curl https://bootstrap.pypa.io/get-pip.py -o get-pip.py && python3 get-pip.py && \ | ||
pip install conan && \ | ||
conan remote add bincrafters https://api.bintray.com/conan/bincrafters/public-conan | ||
|
||
COPY . /fbx2gltf | ||
|
||
WORKDIR /fbx2gltf | ||
|
||
# Install FBX SDK | ||
RUN curl -L https://www.autodesk.com/content/dam/autodesk/www/adn/fbx/20192/fbx20192_fbxsdk_linux.tar.gz -o fbx20192_fbxsdk_linux.tar.gz && \ | ||
tar -xvf fbx20192_fbxsdk_linux.tar.gz && \ | ||
echo "yes\nn" | ./fbx20192_fbxsdk_linux /fbx2gltf/sdk/Linux/2019.2 && \ | ||
rm -rf /fbxsdktemp | ||
|
||
# Build and install | ||
RUN conan install . -i docker-build -s build_type=Release -s compiler=gcc -s compiler.version=5 -s compiler.libcxx=libstdc++11 && \ | ||
conan build -bf docker-build . && \ | ||
cp docker-build/FBX2glTF /usr/bin && \ | ||
cd / && \ | ||
rm -rf /fbx2gltf /root/.conan |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
version: '3.7' | ||
services: | ||
fbx2gltf: | ||
build: | ||
context: . |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this COPY be easily made to skip "./sdk/" by any chance? That's a lot of pointless data, if you're sure GIT LFS is not reliable everywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should be able to add that to
.dockerignore
. The large copy wouldn't be an issue for docker hub builds because git lfs files haven't been pulled, but I can see this as useful for local builds.