Refinement and Documentation of macOS TTPs #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d3sch41n
previously requested changes
Sep 6, 2023
Good call, I didn't remember we had that option. I'll update the PR. |
TTPForge-bot
added
area/github
TTPForge-bot
removed
area/github
TTPForge-bot
added
area/github
- Updated README to reflect removal of `use_swift` argument. - Modified launchagent.swift to support a generic shell script, rather than just opening Calculator. - Enhanced the YAML to handle the default script creation if not provided. - Streamlined error handling in the Swift code. - Adjusted cleanup logic in the YAML.
…scripts with Swift. - Updated the README to reflect changes and use cases. - Added missing loginitem TTP - Update linting rule to allow unordered nested lists
- Fixed bug with creating the plist file - Updated the README.md file to include a default example with no arguments - Improved error handling and added informative print statements for better debugging.
- Fixed warnings in loginitem.swift - Fixed warnings that were viable to fix in cleanuploginitem.swift - Updated the README.md file to include a default example with no arguments - Improved error handling and added informative print statements for better debugging.
… Handling (facebookincubator#61) * Add missing set -e * Add pre-commit hook to append "Authored-by" to commit messages - Created a new script `.hooks/add-authored-by.sh` which: - Checks if git is installed. - Verifies if the `user.name` and `user.email` git configurations are set. - Appends the "Authored-by" line to the commit message. - Updated `.pre-commit-config.yaml` to include this script as a `commit-msg` stage hook. * Ensure duplicate signatures aren't possible * Add additional error checking Authored-by: Jayson Grace <jayson.e.grace@gmail.com> * Remove unimplemented mage function Authored-by: Jayson Grace <jayson.e.grace@gmail.com> * Removed commented code Authored-by: Jayson Grace <jayson.e.grace@gmail.com> * Update prettier version and add commit-msg hook installation - Bump prettier version from v3.0.2 to v3.0.3 in pre-commit config. - Enhance `magefiles/magefile.go` to: - Import required modules for file path handling and system utilities. - Implement a new `installCommitMsgHook` function that ensures the `commit-msg` hook is set up. - Integrate the `installCommitMsgHook` within the `RunPreCommit` function to automate its execution. Authored-by: Jayson Grace <jayson.e.grace@gmail.com>
- Added expect script back to capture output - Added additional instructions to TTP pre-requisites
- Can't have `set -e` in either section, otherwise it will error out.
- Resolves bug in remove-quarantine-attrib TTP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I accidentally hosed #37, so here's a new one:
Proposed Changes
Related Issue(s)
N/A
Testing
Every TTP was run after changes were made.
Documentation
Added README to every macOS TTP
Screenshots/GIFs (optional)
N/A
Checklist
mage runprecommitlocally and fixed any issues that arose.