Example updates #82
Merged
Example updates #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l50
requested review from
d3sch41n,
cedowens,
godlovepenn and
twinvega
as code owners
l50
force-pushed
the
example-updates
branch
from
b58cc95 to
f61196e
Compare
|
Back from PTO - I need to review the targets TTPForge PR today, however everything else looks fine so if you want to set the targets docs to the side for a bit, can merge everything else now - LMK |
All good, I'll wait on your review before we merge. |
Authored-by: Jayson Grace <jayson.e.grace@gmail.com>
- Enhanced titles and descriptions for improved comprehension. - Streamlined instructions for running demonstrations. - Adjusted formatting for better visual distinction of sections. - Renamed certain files for naming consistency. Authored-by: Jayson Grace <jayson.e.grace@gmail.com>
l50
force-pushed
the
example-updates
branch
from
f61196e to
cb068b3
Compare
Authored-by: Jayson Grace <jayson.e.grace@gmail.com>
d3sch41n
requested changes
Sep 21, 2023
- Need to work on targets a bit more - We're not going to add `ignore_errors` - it has the potential to create a lot of quality control issues Authored-by: Jayson Grace <jayson.e.grace@gmail.com>
l50
force-pushed
the
example-updates
branch
from
dcabf3a to
2760837
Compare
Whoops, good catch! Done. |
Authored-by: Jayson Grace <jayson.e.grace@gmail.com>
d3sch41n
reviewed
Sep 22, 2023
| cat file-to-edit.txt | ||
| - name: edit-target-file | ||
| edit_file: "file-to-edit.txt" | ||
| backup_file: "my-backup.txt" | ||
| backup_file: "/tmp/my-backup.txt" |
There was a problem hiding this comment.
Sounds good. Yeah, basically it drops the backup in the CWD, which is different from where Forge expects it to be in relation to the original file. Hence the absolute path.
d3sch41n
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This pull request (PR) proposes documentation updates for the TTPForge project based on the changes made in the recent commit. The changes include updates to several README files within the
ttps/examplesdirectory, specifically:Updates to
argsexample:Created
mitreexamplemitreexample with a README describing the functionality of the step and how to run it.Updates to
outputsexample:Updates to
edit-stepexampleUpdates to
sub-ttpsexampleCreated
fetchuriexample:fetchuriexample with a README describing the functionality of the step and how to run it.Related Issue(s)
No related issues are associated with this PR.
Testing
N/A
Documentation
Updated and added documentation for various TTP examples within the
ttps/examplesdirectory.Screenshots/GIFs (optional)
N/A
Checklist
mage runprecommitlocally and fixed any issues that arose.