Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update detections to use us-east-1 specifically #91

Merged
merged 2 commits into from
Oct 3, 2023
Merged

Update detections to use us-east-1 specifically #91

merged 2 commits into from
Oct 3, 2023

Conversation

l50
Copy link
Contributor

@l50 l50 commented Oct 2, 2023 •
edited
Loading

Proposed Changes

  • Updated detections for cloud TTPs to use us-east-1. This will allow us to minimize false negatives.
  • Added missing MITRE mappings to cloud TTPs and docs

Related Issue(s)

N/A

Testing

Tested all affected TTPs.

Documentation

N/A

Screenshots/GIFs (optional)

N/A

Checklist

  • Ran mage runprecommit locally and fixed any issues that arose.
  • Curated your commit(s) so they are legible and easy to read and understand.
  • 🚀

@l50 l50 merged commit 862f57e into facebookincubator:main Oct 3, 2023
4 checks passed
@l50 l50 deleted the fix-cloud-detections branch October 3, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d3sch41n d3sch41n d3sch41n approved these changes

@cedowens cedowens Awaiting requested review from cedowens cedowens is a code owner

@godlovepenn godlovepenn Awaiting requested review from godlovepenn

@twinvega twinvega Awaiting requested review from twinvega

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@l50 @d3sch41n @facebook-github-bot