Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apple rejects app due to _closeConnection, _openConnection usage #263

Closed
nickbit opened this issue Jul 24, 2015 · 6 comments · Fixed by #269
Closed

Apple rejects app due to _closeConnection, _openConnection usage #263

nickbit opened this issue Jul 24, 2015 · 6 comments · Fixed by #269

Comments

@nickbit
Copy link

nickbit commented Jul 24, 2015

In short avoid to name methods as _xxx
@mk
Copy link
Contributor

mk commented Aug 13, 2015

did you get rejected for those method names? We're thinking of updating SocketRocket and we'd be happy to provide a PR that changes the method names. Seems like #226 and it's PR #252 were meant to fix any app store issues.

@nickbit
Copy link
Author

nickbit commented Aug 13, 2015

yes we got rejected for using those names. It seems that they use them also in some private framework and don't like for others to use them (they think we are using their private framework).

@mk
Copy link
Contributor

mk commented Aug 13, 2015

thanks for letting me know! Probably best to remove any underscore prefixes from method names in SocketRocket then.

kommen added a commit to kommen/SocketRocket that referenced this issue Aug 14, 2015
@kommen
Remove _ from _openConnection and _closeConnection. facebookincubator…
db8c681 
…#263

facebookincubator#263
@brandons
Copy link

brandons commented Sep 4, 2015

Can we please get this fixed? @kommen can you submit a PR?

@kommen kommen mentioned this issue Sep 6, 2015
Merged
@kommen
Copy link
Contributor

kommen commented Sep 6, 2015

@brandons: Here you are: #269

@dfed dfed closed this as completed in #269 Sep 10, 2015
dfed added a commit that referenced this issue Sep 10, 2015
@dfed
Merge pull request #269 from kommen/unprefix-method-names
5ba1c8a 
Remove underscore from _openConnection and _closeConnection. #263
@dfed
Copy link
Contributor

dfed commented Sep 10, 2015

version 0.4.1 has this fix.

@brandons brandons mentioned this issue Sep 11, 2015
Merged
scottcc added a commit to binnj/SocketRocket that referenced this issue Sep 18, 2015
@scottcc
Merge branch 'square-master'
325bcef 
* square-master:
  Bump pod version to 0.4.1
  Remove _ from _openConnection and _closeConnection. facebookincubator#263
  Make SRWebSocket.h public
  CI should validate the pod spec
  Remove unnecessary run script
  Update version number to 0.4
  In iOS 9 / El Cap, NSTimer enforces non-nullability of target/action.
  Do not use Apple method names _connect and _disconnect
  Update podspec
  Add Travis CI
  Update .gitignore
  Move to XCTest
  Suppress OCUnit warnings in Xcode 6.4
  Fix 64 bit build error
  64 bit + Warnings As Errors
  Adopting Modern Objective-C for enum
  Ignore deprecation warnings for older iOS versions
  Fix unused variables

Conflicts:
	SocketRocket.podspec
	SocketRocket/SRWebSocket.m
PetroccoCo added a commit to PetroccoCo/SocketRocket that referenced this issue Sep 18, 2015
@PetroccoCo
Merge remote-tracking branch 'upstream/master'
bb36a66 
* upstream/master: (47 commits)
  Bump pod version to 0.4.1
  Remove _ from _openConnection and _closeConnection. facebookincubator#263
  Make SRWebSocket.h public
  CI should validate the pod spec
  Remove unnecessary run script
  Update version number to 0.4
  In iOS 9 / El Cap, NSTimer enforces non-nullability of target/action.
  Do not use Apple method names _connect and _disconnect
  Update podspec
  Add Travis CI
  Update .gitignore
  Move to XCTest
  Suppress OCUnit warnings in Xcode 6.4
  Fix 64 bit build error
  64 bit + Warnings As Errors
  Adopting Modern Objective-C for enum
  Ignore deprecation warnings for older iOS versions
  Fix unused variables
  Update README.rst
  Update to recommended project settings: Enable strict objc_msgSend checking and unreachable code detection. Ignore architecture selection suggestions.
  ...
jmkk pushed a commit to jmkk/SocketRocket that referenced this issue Sep 19, 2015
@kommen @jmkk
Remove _ from _openConnection and _closeConnection. facebookincubator…
f094f3b 
…#263

facebookincubator#263
jessearmand added a commit to jessearmand/SocketRocket that referenced this issue Oct 6, 2015
@jessearmand
Merge remote-tracking branch 'origin/master'
3baaaa8 
* origin/master: (26 commits)
  cherry picking facebookincubator#74 and fixing merge conflicts
  Fix Autobahn link in README
  Make chatroom.go pass golint and gofmt
  Added ability to provide cookies for the web socket connection
  Update gitignore
  Update gitconfig
  Bump pod version to 0.4.1
  Remove _ from _openConnection and _closeConnection. facebookincubator#263
  Make SRWebSocket.h public
  CI should validate the pod spec
  Remove unnecessary run script
  Update version number to 0.4
  In iOS 9 / El Cap, NSTimer enforces non-nullability of target/action.
  Do not use Apple method names _connect and _disconnect
  Update podspec
  Add Travis CI
  Update .gitignore
  Move to XCTest
  Suppress OCUnit warnings in Xcode 6.4
  Fix 64 bit build error
  ...
madlymad pushed a commit to madlymad/SocketRocket that referenced this issue Jul 6, 2017
@kommen
Remove _ from _openConnection and _closeConnection. facebookincubator…
4644ac5 
…#263

facebookincubator#263
madlymad pushed a commit to madlymad/SocketRocket that referenced this issue Jul 6, 2017
@dfed
Merge pull request facebookincubator#269 from kommen/unprefix-method-…
eca5bd2 
…names

Remove underscore from _openConnection and _closeConnection. facebookincubator#263
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove underscore from _openConnection and _closeConnection. #263 kommen/SocketRocket
5 participants
@kommen @mk @brandons @dfed @nickbit