Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a note for OSX users about watchman and jest #1080

Merged
merged 3 commits into from
Nov 23, 2016
Merged

Conversation

dmr
Copy link
Contributor

@dmr dmr commented Nov 21, 2016

Minor additional information on how to solve watchman problems reported in #713 and #1767

Minor additional information on how to solve watchman problems reported in facebook#713 and facebook#1767
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

@gaearon
Copy link
Contributor

gaearon commented Nov 21, 2016

Can you create a new top-level Troubleshooting section at the very end and put it there? We'll have a few more troubleshooting recipes.

Copy link
Contributor

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move to a separate section and fix nits

@@ -675,6 +675,14 @@ The watcher includes an interactive command-line interface with the ability to r

![Jest watch mode](http://facebook.github.io/jest/img/blog/15-watch.gif)

>**A note for Mac OSX users**

>If you start `npm test` and the execution hangs there might be a problem with your watchman installation as discovered in #713 and #1767.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make watchman and issues links.


>If you start `npm test` and the execution hangs there might be a problem with your watchman installation as discovered in #713 and #1767.

> To solve the issues first make sure you run the latest verision: `brew install watchman` (4.7.0).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo, should be "version".
Let's not hardcode specific version but say "make sure you run at least watchman 4.7.0 or newer".

Add better explanation how to solve facebook#713 and linked related Issues.
@dmr
Copy link
Contributor Author

dmr commented Nov 23, 2016

Thank you for your feedback, I added the new section as you requested and linked the articles

@gaearon
Copy link
Contributor

gaearon commented Nov 23, 2016

Thanks! I tweaked the wording a little. Really appreciate it!

@gaearon gaearon merged commit 66adb3e into facebook:master Nov 23, 2016
jarlef pushed a commit to jarlef/create-react-app that referenced this pull request Nov 28, 2016
* Add a note for OSX users about watchman and jest

Minor additional information on how to solve watchman problems reported in facebook#713 and facebook#1767

* Introduced new Troubleshooting section

Add better explanation how to solve facebook#713 and linked related Issues.

* Tweak wording and add it to TOC
@fson fson added this to the 0.8.0 milestone Dec 3, 2016
alexdriaguine pushed a commit to alexdriaguine/create-react-app that referenced this pull request Jan 23, 2017
* Add a note for OSX users about watchman and jest

Minor additional information on how to solve watchman problems reported in facebook#713 and facebook#1767

* Introduced new Troubleshooting section

Add better explanation how to solve facebook#713 and linked related Issues.

* Tweak wording and add it to TOC
randycoulman pushed a commit to CodingZeal/create-react-app that referenced this pull request May 8, 2017
* Add a note for OSX users about watchman and jest

Minor additional information on how to solve watchman problems reported in facebook#713 and facebook#1767

* Introduced new Troubleshooting section

Add better explanation how to solve facebook#713 and linked related Issues.

* Tweak wording and add it to TOC
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants