Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deploy to Firebase CDN on template's README (Closes #374) #1143

Merged
merged 2 commits into from
Dec 5, 2016

Conversation

guilhermebruzzi
Copy link
Contributor

A step by step guide to deploying a recent created react app (with create-react-app) to the Firebase CDN.

@guilhermebruzzi
Copy link
Contributor Author

guilhermebruzzi commented Dec 3, 2016

@gaearon You said in an issue that a PR explaining how to deploy to the Firebase CDN would be a good contribution, so i just sent a PR to solve it, feel free to comment about it! :)

@gaearon
Copy link
Contributor

gaearon commented Dec 5, 2016

Thanks! I'm a bit behind the schedule reviewing things, sorry for that.

@gaearon gaearon merged commit 023a5d9 into facebook:master Dec 5, 2016
@gaearon
Copy link
Contributor

gaearon commented Dec 5, 2016

Thanks!

@guilhermebruzzi
Copy link
Contributor Author

@gaearon No problem, thank you for your time! :D

mofelee added a commit to xiaohu-developer/create-react-app that referenced this pull request Dec 7, 2016
* master: (30 commits)
  Relax peerDependencies for ESLint preset (facebook#1191)
  Update Webpack to fix source map issues (facebook#1188)
  Update webpack prod config (facebook#1181)
  Chrome 'open tab' reuse an empty tab when possible (facebook#1165)
  Use file-loader for svgs (facebook#1180)
  Fix Babel issues in tests by applying the right transforms (facebook#1179)
  [babel-preset-react-app] Temporary fix missing babel plugins (facebook#1177)
  Add Subresource Integrity support (facebook#1176)
  Remove path module from webpack config on eject. (facebook#1175)
  Don't strip stack traces of evaluated webpack bundles (facebook#1050)
  Add deploy to Firebase CDN on template's README (Closes facebook#374) (facebook#1143)
  Update e2e.sh (facebook#1167)
  Document what npm build does and pushState (facebook#933)
  Fix minor typo/grammar (facebook#1099)
  Add "npm run build silently fails" to Troubleshooting (facebook#1168)
  Add testURL to jest config (facebook#1120)
  Make jsx-no-undef rule an error (facebook#1159)
  Update CHANGELOG.md
  Publish
  Update changelog for 0.8.1
  ...
@gaearon gaearon mentioned this pull request Dec 7, 2016
alexdriaguine pushed a commit to alexdriaguine/create-react-app that referenced this pull request Jan 23, 2017
…facebook#1143)

* Add deploy to Firebase CDN on template's README (Closes facebook#374)

* Move section and minor tweaks
randycoulman pushed a commit to CodingZeal/create-react-app that referenced this pull request May 8, 2017
…facebook#1143)

* Add deploy to Firebase CDN on template's README (Closes facebook#374)

* Move section and minor tweaks
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants