Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use file-loader for svgs #1180

Merged
merged 1 commit into from
Dec 6, 2016
Merged

Conversation

bogdansoare
Copy link
Contributor

This pull request closes issue #1153 .

The problem with base64 inlining svgs is that it breaks fragment identifiers which are used in sprite systems .

If the user wants to inline an svg they could put it directly into components like @gaearon said

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

If you are contributing on behalf of someone else (eg your employer): the individual CLA is not sufficient - use https://developers.facebook.com/opensource/cla?type=company instead. Contact cla@fb.com if you have any questions.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@gaearon gaearon added this to the 0.8.2 milestone Dec 6, 2016
@gaearon gaearon merged commit 15feb02 into facebook:master Dec 6, 2016
@gaearon
Copy link
Contributor

gaearon commented Dec 6, 2016

Thank you!

@gaearon gaearon mentioned this pull request Dec 6, 2016
mofelee added a commit to xiaohu-developer/create-react-app that referenced this pull request Dec 7, 2016
* master: (30 commits)
  Relax peerDependencies for ESLint preset (facebook#1191)
  Update Webpack to fix source map issues (facebook#1188)
  Update webpack prod config (facebook#1181)
  Chrome 'open tab' reuse an empty tab when possible (facebook#1165)
  Use file-loader for svgs (facebook#1180)
  Fix Babel issues in tests by applying the right transforms (facebook#1179)
  [babel-preset-react-app] Temporary fix missing babel plugins (facebook#1177)
  Add Subresource Integrity support (facebook#1176)
  Remove path module from webpack config on eject. (facebook#1175)
  Don't strip stack traces of evaluated webpack bundles (facebook#1050)
  Add deploy to Firebase CDN on template's README (Closes facebook#374) (facebook#1143)
  Update e2e.sh (facebook#1167)
  Document what npm build does and pushState (facebook#933)
  Fix minor typo/grammar (facebook#1099)
  Add "npm run build silently fails" to Troubleshooting (facebook#1168)
  Add testURL to jest config (facebook#1120)
  Make jsx-no-undef rule an error (facebook#1159)
  Update CHANGELOG.md
  Publish
  Update changelog for 0.8.1
  ...
@gaearon gaearon mentioned this pull request Dec 7, 2016
@gaearon
Copy link
Contributor

gaearon commented Dec 7, 2016

alexdriaguine pushed a commit to alexdriaguine/create-react-app that referenced this pull request Jan 23, 2017
randycoulman pushed a commit to CodingZeal/create-react-app that referenced this pull request May 8, 2017
@mortenko
Copy link

mortenko commented Sep 9, 2017

Hi Guys, I'm considering that problem with SVG is solved ? So, can I use svg in create-react-app? If yes, then documentation should be also updated.

@gaearon
Copy link
Contributor

gaearon commented Sep 10, 2017

There has been no problem with using SVG. And in fact the default generated app contains an SVG.

This issue was specifically about sprites. (Which were also fixed.)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants