Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Yarn detection and install code #1223

Merged
merged 1 commit into from
Dec 10, 2016

Conversation

fson
Copy link
Contributor

@fson fson commented Dec 10, 2016

  • Remove the 'yarn' is not recognized as an internal or external command, ... message on Windows.
  • Simplify the detection code: just run yarn --version – if it succeeds use yarn, if it fails use npm.
  • Pass the --verbose option to Yarn if given, Yarn supports it now.

Tested on macOS and Windows 10.

screen shot 2016-12-10 at 2 43 59

* Remove the “‘yarn’ is not recognized as an internal or external
  command, ...” message on Windows
* Simplify the detection code: just run `yarn --version` – if it
  succeeds use `yarn`, if it fails use `npm`.
@gaearon gaearon added this to the 0.8.4 milestone Dec 10, 2016
Copy link
Contributor

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please merge if Travis passes.

@fson fson merged commit 2e02e36 into facebook:master Dec 10, 2016
@fson fson deleted the cleaner-yarn-detection branch December 10, 2016 01:11
alexdriaguine pushed a commit to alexdriaguine/create-react-app that referenced this pull request Jan 23, 2017
* Remove the “‘yarn’ is not recognized as an internal or external
  command, ...” message on Windows
* Simplify the detection code: just run `yarn --version` – if it
  succeeds use `yarn`, if it fails use `npm`.
randycoulman pushed a commit to CodingZeal/create-react-app that referenced this pull request May 8, 2017
* Remove the “‘yarn’ is not recognized as an internal or external
  command, ...” message on Windows
* Simplify the detection code: just run `yarn --version` – if it
  succeeds use `yarn`, if it fails use `npm`.
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants