Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mjs and jsx filename extensions to file-loader exclude pattern #3537

Merged
merged 1 commit into from
Dec 7, 2017

Conversation

iansu
Copy link
Contributor

@iansu iansu commented Dec 1, 2017

Closes #3520

See issue for steps to reproduce/test.

@Timer
Copy link
Contributor

Timer commented Dec 6, 2017

@Kingdutch can you confirm this fixes #3520?

@Timer Timer added this to the 1.0.17 milestone Dec 6, 2017
@Kingdutch
Copy link

@Timer This is the slightly more explicit version of my suggestion in the issue : )

Applied it locally and it fixes the issue 👍

@Timer
Copy link
Contributor

Timer commented Dec 7, 2017

We like explicitness for beginners who eject. 😄

@Timer Timer merged commit af291f3 into facebook:master Dec 7, 2017
kellyrmilligan added a commit to kellyrmilligan/create-react-app that referenced this pull request Dec 15, 2017
* master:
  Updates comment to reflect codebase (facebook#3576)
  Add mjs and jsx filename extensions to file-loader exclude pattern (facebook#3537)
@frenzzy
Copy link
Contributor

frenzzy commented Jan 1, 2018

@Timer or @gaearon could you release this change please?
By some reason it was not included into v1.0.17, see:

...and we can't use external libs which file extension is .jsx or .mjs 😢

actual:

loader: require.resolve('file-loader'),
exclude: [/\.js$/, /\.html$/, /\.json$/],

expected:

loader: require.resolve('file-loader'),
exclude: [/\.(js|jsx|mjs)$/, /\.html$/, /\.json$/],

Thanks!

@rtsao
Copy link

rtsao commented Jan 10, 2018

Even without ejecting, importing a .mjs file via node_modules is broken with without this (which is not in 1.0.17.

@Timer
Copy link
Contributor

Timer commented Jan 10, 2018

It'll be out in the next release.

@facebook facebook locked and limited conversation to collaborators Jan 10, 2018
@gaearon
Copy link
Contributor

gaearon commented Jan 15, 2018

This is out in react-scripts@1.1.0! Please let us know if something doesn’t quite work.
https://github.com/facebookincubator/create-react-app/releases/tag/v1.1.0

@iansu iansu deleted the file-loader-mjs-jsx branch October 18, 2019 05:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants