Mark DestructorThread as a daemon #67
Conversation
Mark DestructorThread as a daemon so the JVM can exit.
|
Hi @jxtps! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
@passy has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
Hey - has this ever been imported & merged internally? |
Nope. It had a bunch of failures internally and was never merged. @passy can tell more here |
Mark DestructorThread as a daemon so the JVM can exit.
Motivation
Why are you making this change?
To fix #25
Summary
What did you change?
I added
sThread.setDaemon(true), which marks the destructor thread as a so called 'daemon' thread so it doesn't stop the JVM from exiting when all (other) user threads have terminated.How does the code work?
It marks the thread as a daemon (a opposed to user) thread. The JVM keeps running until all user threads exit. This thread never exits.
Why did you choose this approach?
Because this is a textbook daemon thread.
Test Plan
How did you test this change?
See @dreiss code example in #25