Install fbjniLibraryConfig.cmake and headers correctly #76
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's pretty common for the lib directory to be added
to the cmake modules path, but much less so for
share.
This is to better align with dominate cmake pratices.
Motivation
Why?
Met some awkwardness:
Although
/nix/store/grkksx8cdka4vmii6mv9fj9handf36m8-fbjni-0.3.0
was on my CMAKE_PREFIX_PATH, but cmake looks for${CMAKE_PREFIX}/lib/cmake
, not${CMAKE_PREFIX}/share/cmake
Summary
What did you change?
Where it installs the fbjniLibraryConfig.cmake to lib
How does the code work?
GNUInstallDirs + CMake
Why did you choose this approach?
Most common pattern that I've seen
Test Plan
How did you test this change?
Adding a downstream project to test further would probably be good
Any change that adds functionality should add a unit test as well.