Fix OSS Build #92
Closed
Fix OSS Build #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D51146182 |
NickGerleman
added a commit
to NickGerleman/fbjni
that referenced
this pull request
Nov 9, 2023
Summary: Pull Request resolved: facebookincubator#92 Differential Revision: D51146182
Summary: fbjni OSS tests will build a binary using `ubuntu-latest` Clang + stdlibc++ toolchain. https://github.com/facebookincubator/fbjni/blob/main/scripts/run-host-tests.sh The stdlib version changed, and now we fail to build, because `#include <string>` is not pulling in `<cstdint>` for us. Differential Revision: D51146182
NickGerleman
force-pushed
the
export-D51146182
branch
from
bfc5ae4
to
ecc4a89
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51146182 |
|
This pull request has been merged in 59461ef. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D51146182