Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make fizz::ExtensionType compatible with fmt11 #144

Closed
wants to merge 1 commit into from
Closed

Make fizz::ExtensionType compatible with fmt11 #144

wants to merge 1 commit into from

Conversation

miyanyan
Copy link
Contributor

@miyanyan miyanyan commented Aug 2, 2024

starting from fmt11.0.0, fmt requires formatter::format to be const.

Started enforcing that formatter::format is const for compatibility with std::format

@facebook-github-bot
Copy link
Contributor

Hi @miyanyan!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot
Copy link
Contributor

@mingtaoy has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@mingtaoy merged this pull request in f02429b.

facebook-github-bot pushed a commit to facebook/hhvm that referenced this pull request Sep 11, 2024
@miyanyan @facebook-github-bot
Make fizz::ExtensionType compatible with fmt11
2cfe73c 
Summary:
starting from [fmt11.0.0](fmtlib/fmt#3447), fmt requires formatter::format to be const.
> Started enforcing that formatter::format is const for compatibility with std::format

X-link: facebookincubator/fizz#144

Reviewed By: NickR23

Differential Revision: D60912017

Pulled By: mingtaoy

fbshipit-source-id: 49e367c509a84523455220d791402ca4669942bd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miyanyan @facebook-github-bot