Skip to content

Commit

Permalink
address Simon's feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
alpmestan committed Nov 25, 2020
1 parent 1724246 commit d9bdd18
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 17 deletions.
10 changes: 5 additions & 5 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -19,19 +19,19 @@ thrift:: thrift-cpp thrift-hs
THRIFT_COMPILE = $(CABAL) new-run exe:thrift-compiler --

thrift-hs::
$(THRIFT_COMPILE) --hs \
$(THRIFT_COMPILE) --hs --use-int \
lib/if/RpcOptions.thrift \
-o lib
$(THRIFT_COMPILE) --hs \
$(THRIFT_COMPILE) --hs --use-int \
lib/if/ApplicationException.thrift \
-o lib
$(THRIFT_COMPILE) --hs \
$(THRIFT_COMPILE) --hs --use-int \
lib/test/if/math.thrift \
-o lib/test
$(THRIFT_COMPILE) --hs \
$(THRIFT_COMPILE) --hs --use-int \
lib/test/if/echoer.thrift \
-o lib/test
$(THRIFT_COMPILE) --hs \
$(THRIFT_COMPILE) --hs --use-int \
server/test/if/hash_map.thrift \
-o server/test

Expand Down
10 changes: 0 additions & 10 deletions common/util/fb-util.cabal
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,6 @@ library
Util.PrettyPrint
Util.RWVar
Util.Reader
-- Util.Regex
-- seems to be missing?
Util.STM
Util.Show
Util.String
Expand Down Expand Up @@ -370,14 +368,6 @@ test-suite hs-struct
cxx-options: -std=c++17
ghc-options: -main-is HsStructTest

-- TODO: commented out because Util.Regex, the module that this is supposed to
-- test, is currently missing.
-- test-suite regex
-- import: fb-haskell, test-common
-- type: exitcode-stdio-1.0
-- main-is: RegexTest.hs
-- ghc-options: -main-is RegexTest

-- TODO: commented out because of a linker problem
-- test-suite gflags
-- import: fb-haskell, test-common
Expand Down
3 changes: 1 addition & 2 deletions lib/test/ClientTest.hs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import Control.Monad
import Control.Monad.Trans.Class
import Control.Monad.Trans.Reader
import Data.IORef
import Data.Int
import Data.Proxy
import TestRunner
import Test.HUnit hiding (State)
Expand Down Expand Up @@ -97,7 +96,7 @@ runCalculatorServer proxy ch = do
runServer proxy ch $ processCommand state

-- Server Implementation
type State = IORef Int64
type State = IORef Int

initServerState :: IO State
initServerState = newIORef 0
Expand Down

0 comments on commit d9bdd18

Please sign in to comment.