-
Notifications
You must be signed in to change notification settings - Fork 4
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Ensure title exported in SCRUT_TEST contains only printable characters
Summary: This CL changes the value of SCRUT_TEST to contain <file-name>:<line-number> # What? - The value of `SCRUT_TEST` now contains the file-name followed by the line number (e.g. `some/test.md:123`) instead of the file-name followed by the title # Why? The filtering that Scrut uses to make sure some internal variables are passed between executions only works with single-line values. The newly introduced SCRUT_TEST variable was added to that filter list, but it could contain multi-line values (i.e. when a Scrut test title contained multiple lines). This resulted in invalid `state` files that broke subsequent Scrut tests (see failing tests in MSDK, e.g. D60034934) Reviewed By: abesto Differential Revision: D60039617 fbshipit-source-id: e99279c250e8a711d4c51f99c12e1120d702a329
- Loading branch information
1 parent
258826c
commit cf252e3
Showing
3 changed files
with
7 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters