Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Googletest dependencies must be guarded #1654

Closed
majetideepak opened this issue May 19, 2022 · 1 comment
Closed

Googletest dependencies must be guarded #1654

majetideepak opened this issue May 19, 2022 · 1 comment
Labels
build

Comments

@majetideepak
Copy link
Collaborator

majetideepak commented May 19, 2022 •
edited
Loading

When Velox testing is disabled (VELOX_BUILD_TESTING=OFF), I presume we do not need googletest. However, velox/common/memory/Memory.h defines FRIEND_TEST and includes the gtest/gtest_prod.h header.
This can also be reproduced when building presto_cpp with tests disabled.
@majetideepak
Copy link
Collaborator Author

majetideepak commented May 19, 2022 •
edited
Loading

We must also not be building the googletest submodule when testing is disabled.

@majetideepak majetideepak mentioned this issue May 20, 2022
Closed
zhejiangxiaomai pushed a commit to zhejiangxiaomai/velox that referenced this issue Jun 21, 2022
@majetideepak
Build googletest only if testing or basic benchmarking are enabled (f…
42d21e1 
…acebookincubator#1666)

Summary:
Also, adds a dummy definition for`FRIEND_TEST` when googletest is disabled.
Resolves facebookincubator#1654

Pull Request resolved: facebookincubator#1666

Reviewed By: kgpai

Differential Revision: D36664732

Pulled By: mbasmanova

fbshipit-source-id: a08859f96f68d5bc9d2c5092be6f7f397508706f
shiyu-bytedance pushed a commit to shiyu-bytedance/velox-1 that referenced this issue Aug 18, 2022
@majetideepak
Build googletest only if testing or basic benchmarking are enabled (f…
5eb6bbf 
…acebookincubator#1666)

Summary:
Also, adds a dummy definition for`FRIEND_TEST` when googletest is disabled.
Resolves facebookincubator#1654

Pull Request resolved: facebookincubator#1666

Reviewed By: kgpai

Differential Revision: D36664732

Pulled By: mbasmanova

fbshipit-source-id: a08859f96f68d5bc9d2c5092be6f7f397508706f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Build googletest only if testing or basic benchmarking are enabled Ahana-Inc/velox
1 participant
@majetideepak