Tests and benchmarks must be decoupled #1704
Labels
Comments
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
kgpai
pushed a commit
to kgpai/torcharrow
that referenced
this issue
Sep 14, 2022
Summary: Tests and benchmarks targets are now de-coupled. That means they can be built independently. Shared functionality is moved to a common utility library. Resolves facebookincubator/velox#1704 X-link: facebookincubator/velox#2439 Reviewed By: Yuhta Differential Revision: D39484543 Pulled By: kgpai fbshipit-source-id: b8b0f3a2fec4651ee8b4fe9ca6304bd37b9be183
facebook-github-bot
pushed a commit
to pytorch/torcharrow
that referenced
this issue
Sep 15, 2022
Summary: Pull Request resolved: #491 Tests and benchmarks targets are now de-coupled. That means they can be built independently. Shared functionality is moved to a common utility library. Resolves facebookincubator/velox#1704 X-link: facebookincubator/velox#2439 Reviewed By: Yuhta Differential Revision: D39484543 Pulled By: kgpai fbshipit-source-id: 5ac888c81a6bbfbc5a1a1c4cfd41fa2c86199bc4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Some of the tests and benchmarks are coupled to allow the re-use of shared functionality.
See
velox/vector/CMakeLists.txtfor example. The vector benchmarks couple with the testing classes to say accessVectorMakerfunctionality.This is not ideal as it introduces a dependency between benchmarks and the whole testing framework.
A better approach is to move the shared functionality into its own utility library. See
velox/execfor example. The shared utilities are intests/utilsand can be independently enabled usingVELOX_BUILD_TEST_UTILS.The text was updated successfully, but these errors were encountered: