Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump up presto java version in docker container #10254

Closed
wants to merge 1 commit into from
Closed

Bump up presto java version in docker container #10254

wants to merge 1 commit into from

Conversation

kewang1024
Copy link
Contributor

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 19, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 19, 2024 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 821fa27
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/668c15e284ff95000863d712

@kgpai
Copy link
Contributor

kgpai commented Jun 19, 2024

Can you also edit

velox/.github/workflows/docker.yml

Line 18 in f9f6d82

paths:
to add docker-compose.yml . This will ensure the docker image is rebuilt.

@kewang1024 kewang1024 requested a review from kgpai June 19, 2024 22:36
@kgpai
Copy link
Contributor

kgpai commented Jun 20, 2024

cc: @assignUser Do you know why are the docker images still using old presto version ,even though the version is specifically changed here.

@assignUser
Copy link
Collaborator

It seems there is an issue with the file name? https://github.com/facebookincubator/velox/actions/runs/9605868436/job/26498382674?pr=10254#step:5:186

@kgpai
Copy link
Contributor

kgpai commented Jun 21, 2024

@assignUser This is completely expected, the issue was previously why we werent getting it :)

@facebook-github-bot
Copy link
Contributor

@kewang1024 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@kewang1024 merged this pull request in e23df19.

@conbench-facebook conbench-facebook
Copy link

Conbench analyzed the 1 benchmark run on commit e23df195.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgpai kgpai kgpai approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kewang1024 @kgpai @assignUser @facebook-github-bot