Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend ApproxPercentileResultVerifier for window fuzzer #10367

Closed
wants to merge 1 commit into from
Closed

Extend ApproxPercentileResultVerifier for window fuzzer #10367

wants to merge 1 commit into from
+492 −33

Conversation

kagamiori
Copy link
Contributor

Differential Revision: D59257657

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 2, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 2, 2024 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit f85e21d
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/668cad1ae09bda0008c273ea

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59257657

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59257657

kagamiori added a commit to kagamiori/velox that referenced this pull request Jul 2, 2024
@kagamiori @facebook-github-bot
Extend ApproxPercentileResultVerifier for window fuzzer (facebookincu…
3de0b13 
…bator#10367)

Summary: Pull Request resolved: facebookincubator#10367

Differential Revision: D59257657
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59257657

kagamiori added a commit to kagamiori/velox that referenced this pull request Jul 2, 2024
@kagamiori @facebook-github-bot
Extend ApproxPercentileResultVerifier for window fuzzer (facebookincu…
48450bc 
…bator#10367)

Summary: Pull Request resolved: facebookincubator#10367

Differential Revision: D59257657
kevinwilfong
kevinwilfong approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@kevinwilfong kevinwilfong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just a few comments, could you also address the internal lint issues?

velox/functions/prestosql/fuzzer/ApproxPercentileResultVerifier.h
@@ -106,6 +134,13 @@ class ApproxPercentileResultVerifier : public ResultVerifier {
return false;
}
}
if (verifyWindow_ && numNonNull != allRanges_->size()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you need the condition on verifyWindow_? I think this would have caught the bug I fixed in my previous change to this class where we were losing the first percentile

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we do need verifyWindow_ here because for the verification for aggregation fuzzer, the number of non-null rows in result doesn't necessarily match the number of non-null rows in allRanges_, so we cannot compare them.

velox/functions/prestosql/fuzzer/ApproxPercentileResultVerifier.h
return "partition by " + folly::join(", ", partitionByKeys);
}

// For each input row, calculates a map of {value : [order_min, order_max]} as
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding such a detailed comment!

velox/functions/prestosql/fuzzer/ApproxPercentileResultVerifier.h Outdated
// c1,
// row_num,
// bucket_element,
// SUM(bucket_weight) AS weight
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I removed this aggregation.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59257657

kagamiori added a commit to kagamiori/velox that referenced this pull request Jul 8, 2024
@kagamiori @facebook-github-bot
Extend ApproxPercentileResultVerifier for window fuzzer (facebookincu…
7151ca7 
…bator#10367)

Summary: Pull Request resolved: facebookincubator#10367

Reviewed By: kevinwilfong

Differential Revision: D59257657
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59257657

kagamiori added a commit to kagamiori/velox that referenced this pull request Jul 9, 2024
@kagamiori @facebook-github-bot
Extend ApproxPercentileResultVerifier for window fuzzer (facebookincu…
d850c4f 
…bator#10367)

Summary: Pull Request resolved: facebookincubator#10367

Reviewed By: kevinwilfong

Differential Revision: D59257657
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59257657

kagamiori added a commit to kagamiori/velox that referenced this pull request Jul 9, 2024
@kagamiori @facebook-github-bot
Extend ApproxPercentileResultVerifier for window fuzzer (facebookincu…
d2cebc4 
…bator#10367)

Summary: Pull Request resolved: facebookincubator#10367

Reviewed By: kevinwilfong

Differential Revision: D59257657
@kagamiori @facebook-github-bot
Extend ApproxPercentileResultVerifier for window fuzzer (facebookincu…
f85e21d 
…bator#10367)

Summary: Pull Request resolved: facebookincubator#10367

Reviewed By: kevinwilfong

Differential Revision: D59257657
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59257657

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 3d19d04.

@conbench-facebook conbench-facebook
Copy link

Conbench analyzed the 1 benchmark run on commit 3d19d04e.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinwilfong kevinwilfong kevinwilfong approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kagamiori @facebook-github-bot @kevinwilfong