support to read binary as string in parquet #10399
Open
+74
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
Yuhta
reviewed
Jul 4, 2024
majetideepak
reviewed
Jul 8, 2024
| @@ -655,12 +653,17 @@ TypePtr ReaderBase::convertType( | |||
| return DOUBLE(); | |||
| case thrift::Type::type::BYTE_ARRAY: | |||
| case thrift::Type::type::FIXED_LEN_BYTE_ARRAY: | |||
| if (binaryAsString) { | |||
| return VARCHAR(); | |||
| if (options_.fileSchema()->containsChild(schemaElement.name)) { | |||
There was a problem hiding this comment.
Should this be
auto requestedType = options_.requestedType() ? options_.requestedType(): schema();
Yuhta
reviewed
Jul 8, 2024
| @@ -655,12 +653,18 @@ TypePtr ReaderBase::convertType( | |||
| return DOUBLE(); | |||
| case thrift::Type::type::BYTE_ARRAY: | |||
| case thrift::Type::type::FIXED_LEN_BYTE_ARRAY: | |||
| if (binaryAsString) { | |||
| return VARCHAR(); | |||
| if (options_.fileSchema() != nullPtr | |||
There was a problem hiding this comment.
You probably need to add requestedType to getParquetColumnInfo to handle nested VARBINARY as well
Yuhta
reviewed
Jul 9, 2024
| const TypePtr& ReaderBase::getChildRequestedSchema( | ||
| const TypePtr& requestedSchema, | ||
| std::string& name) const { | ||
| if (!requestedSchema && requestedSchema->isRow() && |
There was a problem hiding this comment.
if (!requestedSchema) {
VELOX_CHECK(requestedSchema->isRow() && requestedSchema->asRow().containsChild(name));
} else {| TypePtr ReaderBase::convertType( | ||
| const thrift::SchemaElement& schemaElement) const { | ||
| const thrift::SchemaElement& schemaElement, | ||
| const TypePtr& requestedSchema) const { |
There was a problem hiding this comment.
Here it is requestedType not requestedSchema
| if (binaryAsString) { | ||
| return VARCHAR(); | ||
| case thrift::Type::type::FIXED_LEN_BYTE_ARRAY: { | ||
| if (requestedSchema != nullptr && requestedSchema->isRow() && |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Some other Parquet-producing systems, in particular Impala, will write string-type data as binary into Parquet file. and Velox's ParquetReader does not support binaryAsString. this PR is intended to resolve this issue.
issue resolved: [#10398]