Cache operation support for Prestissimo #10401
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
xiaoxmeng
force-pushed
the
cache
branch
7 times, most recently
from
a07b603
to
7406f86
Compare
|
@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Yuhta
approved these changes
Jul 5, 2024
zacw7
approved these changes
Jul 5, 2024
|
This pull request was exported from Phabricator. Differential Revision: D59401173 |
|
This pull request was exported from Phabricator. Differential Revision: D59401173 |
xiaoxmeng
added a commit
to xiaoxmeng/velox
that referenced
this pull request
Jul 5, 2024
Summary: Add checkpoint and ssd write functions support for Prestissimo worker to operate the cache for performance tuning and online debugging in a test environment Add metrics about how many ssd cache entries are recovered and how many in-memory cache entries are evicted without saving to SSD. Other logs improvements. Pull Request resolved: facebookincubator#10401 Reviewed By: Yuhta, zacw7 Differential Revision: D59401173 Pulled By: xiaoxmeng
xiaoxmeng
added a commit
to xiaoxmeng/velox
that referenced
this pull request
Jul 5, 2024
Summary: Add checkpoint and ssd write functions support for Prestissimo worker to operate the cache for performance tuning and online debugging in a test environment Add metrics about how many ssd cache entries are recovered and how many in-memory cache entries are evicted without saving to SSD. Other logs improvements. Pull Request resolved: facebookincubator#10401 Reviewed By: Yuhta, zacw7 Differential Revision: D59401173 Pulled By: xiaoxmeng
|
This pull request was exported from Phabricator. Differential Revision: D59401173 |
|
This pull request was exported from Phabricator. Differential Revision: D59401173 |
xiaoxmeng
added a commit
to xiaoxmeng/velox
that referenced
this pull request
Jul 5, 2024
Summary: Add checkpoint and ssd write functions support for Prestissimo worker to operate the cache for performance tuning and online debugging in a test environment Add metrics about how many ssd cache entries are recovered and how many in-memory cache entries are evicted without saving to SSD. Other logs improvements. Pull Request resolved: facebookincubator#10401 Reviewed By: Yuhta, zacw7, oerling Differential Revision: D59401173 Pulled By: xiaoxmeng
xiaoxmeng
added a commit
to xiaoxmeng/velox
that referenced
this pull request
Jul 5, 2024
Summary: Add checkpoint and ssd write functions support for Prestissimo worker to operate the cache for performance tuning and online debugging in a test environment Add metrics about how many ssd cache entries are recovered and how many in-memory cache entries are evicted without saving to SSD. Other logs improvements. Pull Request resolved: facebookincubator#10401 Reviewed By: Yuhta, zacw7, oerling Differential Revision: D59401173 Pulled By: xiaoxmeng
xiaoxmeng
added a commit
to xiaoxmeng/velox
that referenced
this pull request
Jul 5, 2024
Summary: Add checkpoint and ssd write functions support for Prestissimo worker to operate the cache for performance tuning and online debugging in a test environment Add metrics about how many ssd cache entries are recovered and how many in-memory cache entries are evicted without saving to SSD. Other logs improvements. Pull Request resolved: facebookincubator#10401 Reviewed By: Yuhta, zacw7, oerling Differential Revision: D59401173 Pulled By: xiaoxmeng
|
This pull request was exported from Phabricator. Differential Revision: D59401173 |
Summary: Add checkpoint and ssd write functions support for Prestissimo worker to operate the cache for performance tuning and online debugging in a test environment Add metrics about how many ssd cache entries are recovered and how many in-memory cache entries are evicted without saving to SSD. Other logs improvements. Pull Request resolved: facebookincubator#10401 Reviewed By: Yuhta, zacw7, oerling Differential Revision: D59401173 Pulled By: xiaoxmeng
|
This pull request was exported from Phabricator. Differential Revision: D59401173 |
|
@xiaoxmeng merged this pull request in 07684ea. |
|
Conbench analyzed the 3 benchmark runs on commit There was 1 benchmark result indicating a performance regression:
The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add checkpoint and ssd write functions support for Prestissimo worker to operate the
cache for performance tuning and online debugging in a test environment
Add metrics about how many ssd cache entries are recovered and how many in-memory
cache entries are evicted without saving to SSD.
Other logs improvements.