Fix snake_case naming codestyle in Filter #10403
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
`is_deterministic` -> `deterministic` Velox do not use 'snake_case' for local variables. No functional changes.
lingbin
force-pushed
the
fix-code-style-in-Filter
branch
from
ba951fc
to
3ff1056
Compare
lingbin
commented
Jul 5, 2024
| @@ -1275,7 +1273,6 @@ class AbstractRange : public Filter { | |||
| return obj; | |||
| } | |||
|
|
|||
| protected: | |||
There was a problem hiding this comment.
It is already in the protected area and the location is very close(L1251), so there is no need to write it again, remove it.
Yuhta
approved these changes
Jul 5, 2024
Yuhta
added
the
ready-to-merge
|
@pedroerp has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is_deterministic->deterministicVelox do not use 'snake_case' for local variables.
No functional changes.