-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix minor doc typos in SelectiveColumnReader.h #10835
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
Aug 26, 2024
✅ Deploy Preview for meta-velox canceled.
|
This pull request was exported from Phabricator. Differential Revision: D61815649 |
Yuhta
approved these changes
Aug 26, 2024
This pull request was exported from Phabricator. Differential Revision: D61815649 |
sdruzkin
force-pushed
the
export-D61815649
branch
from
August 26, 2024 20:48
3c51c83
to
8e00ca3
Compare
sdruzkin
added a commit
to sdruzkin/velox
that referenced
this pull request
Aug 26, 2024
Summary: Pull Request resolved: facebookincubator#10835 Differential Revision: D61815649
Summary: Pull Request resolved: facebookincubator#10835 Reviewed By: xiaoxmeng, Yuhta Differential Revision: D61815649
This pull request was exported from Phabricator. Differential Revision: D61815649 |
sdruzkin
force-pushed
the
export-D61815649
branch
from
August 26, 2024 23:49
8e00ca3
to
79e052c
Compare
This pull request has been merged in 72c4921. |
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Sep 2, 2024
Summary: Pull Request resolved: facebookincubator#10835 Reviewed By: xiaoxmeng, Yuhta Differential Revision: D61815649 fbshipit-source-id: 20e11fd6dc1a19c249b52884dd26cdef156d4b21
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Sep 3, 2024
Summary: Pull Request resolved: facebookincubator#10835 Reviewed By: xiaoxmeng, Yuhta Differential Revision: D61815649 fbshipit-source-id: 20e11fd6dc1a19c249b52884dd26cdef156d4b21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D61815649