Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable probe spill with dynamic filter replaced #10849

Closed
wants to merge 1 commit into from

Conversation

xiaoxmeng
Copy link
Contributor

@xiaoxmeng xiaoxmeng commented Aug 27, 2024

Enable probe spill with dynamic filter replaced. Now the fuzzer test can pass 10hrs run and the
previous issue in table scan for lazy vector processing might have been fixed.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 27, 2024
Copy link

netlify bot commented Aug 27, 2024

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit d53eec8
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/66d409d93b4df40008ed2b70

@facebook-github-bot
Copy link
Contributor

@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61834373

xiaoxmeng added a commit to xiaoxmeng/velox that referenced this pull request Aug 31, 2024
)

Summary:
Enable probe spill with dynamic filter replaced. Now the fuzzer test can pass 10hrs run and the
previous issue in table scan for lazy vector processing might have been fixed.

Pull Request resolved: facebookincubator#10849

Differential Revision: D61834373

Pulled By: xiaoxmeng
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61834373

xiaoxmeng added a commit to xiaoxmeng/velox that referenced this pull request Aug 31, 2024
)

Summary:
Enable probe spill with dynamic filter replaced. Now the fuzzer test can pass 10hrs run and the
previous issue in table scan for lazy vector processing might have been fixed.

Pull Request resolved: facebookincubator#10849

Differential Revision: D61834373

Pulled By: xiaoxmeng
@xiaoxmeng xiaoxmeng marked this pull request as ready for review August 31, 2024 18:05
@xiaoxmeng xiaoxmeng changed the title [wIP]Enable probe spill with dynamic filter replaced Enable probe spill with dynamic filter replaced Aug 31, 2024
)

Summary:
Enable probe spill with dynamic filter replaced. Now the fuzzer test can pass 10hrs run and the
previous issue in table scan for lazy vector processing might have been fixed.

Pull Request resolved: facebookincubator#10849

Reviewed By: gggrace14, tanjialiang

Differential Revision: D61834373

Pulled By: xiaoxmeng
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61834373

@facebook-github-bot
Copy link
Contributor

@xiaoxmeng merged this pull request in 6e52cbd.

Copy link

Conbench analyzed the 1 benchmark run on commit 6e52cbda.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

@xiaoxmeng xiaoxmeng deleted the replace branch September 1, 2024 19:16
Joe-Abraham pushed a commit to Joe-Abraham/velox that referenced this pull request Sep 2, 2024
)

Summary:
Enable probe spill with dynamic filter replaced. Now the fuzzer test can pass 10hrs run and the
previous issue in table scan for lazy vector processing might have been fixed.

Pull Request resolved: facebookincubator#10849

Reviewed By: gggrace14, tanjialiang

Differential Revision: D61834373

Pulled By: xiaoxmeng

fbshipit-source-id: bc5361f16eb25ad6867c556b1cd78583be494bd4
Joe-Abraham pushed a commit to Joe-Abraham/velox that referenced this pull request Sep 3, 2024
)

Summary:
Enable probe spill with dynamic filter replaced. Now the fuzzer test can pass 10hrs run and the
previous issue in table scan for lazy vector processing might have been fixed.

Pull Request resolved: facebookincubator#10849

Reviewed By: gggrace14, tanjialiang

Differential Revision: D61834373

Pulled By: xiaoxmeng

fbshipit-source-id: bc5361f16eb25ad6867c556b1cd78583be494bd4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants