Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Buffer::slice API #11001

Closed
wants to merge 7 commits into from
Closed

Introduce Buffer::slice API #11001

wants to merge 7 commits into from

Conversation

zhli1142015
Copy link
Contributor

@zhli1142015 zhli1142015 commented Sep 13, 2024 •
edited by mbasmanova
Loading

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 13, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 13, 2024 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 9999345
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/66f0a7f60e92d700082b7bf8

@zhli1142015 zhli1142015 mentioned this pull request Sep 13, 2024
Open
@zhli1142015
Copy link
Contributor Author

CI failures are not related to this PR, thanks.

@zhli1142015
Copy link
Contributor Author

CI failure is not related to this PR, open an issue for it: #11035.
Thanks.

@zhli1142015
Copy link
Contributor Author

@mbasmanova , could you help check again? Thanks.

@mbasmanova mbasmanova changed the title Make sliceBuffer a public api Make BaseVector::sliceBuffer a public api Sep 19, 2024
@mbasmanova mbasmanova changed the title Make BaseVector::sliceBuffer a public api Make BaseVector::sliceBuffer public Sep 19, 2024
mbasmanova
mbasmanova reviewed Sep 19, 2024
View reviewed changes
Copy link
Contributor

@mbasmanova mbasmanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Some remaining comments.

velox/vector/BaseVector.h Outdated Show resolved Hide resolved
velox/vector/BaseVector.h Outdated Show resolved Hide resolved
velox/vector/tests/VectorTest.cpp Outdated Show resolved Hide resolved
velox/vector/BaseVector.cpp Outdated Show resolved Hide resolved
Yuhta
Yuhta reviewed Sep 19, 2024
View reviewed changes
velox/vector/BaseVector.cpp Outdated Show resolved Hide resolved
velox/vector/BaseVector.cpp Outdated Show resolved Hide resolved
@zhli1142015 zhli1142015 force-pushed the public_sliceBuffer branch 2 times, most recently from 01715ab to 67981b7 Compare September 20, 2024 06:20
@zhli1142015 zhli1142015 force-pushed the public_sliceBuffer branch 2 times, most recently from 934d079 to 38fa570 Compare September 20, 2024 13:15
@mbasmanova mbasmanova changed the title Make BaseVector::sliceBuffer public Introduce Buffer::slice API Sep 20, 2024
mbasmanova
mbasmanova approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@mbasmanova mbasmanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

velox/buffer/Buffer.h Outdated Show resolved Hide resolved
velox/buffer/Buffer.h Outdated Show resolved Hide resolved
velox/buffer/Buffer.h Outdated Show resolved Hide resolved
velox/buffer/Buffer.h Outdated Show resolved Hide resolved
@mbasmanova mbasmanova added the ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall label Sep 20, 2024
@facebook-github-bot
Copy link
Contributor

@Yuhta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@Yuhta merged this pull request in 83d6609.

@conbench-facebook conbench-facebook
Copy link

Conbench analyzed the 1 benchmark run on commit 83d66099.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbasmanova mbasmanova mbasmanova approved these changes

@pedroerp pedroerp Awaiting requested review from pedroerp

@Yuhta Yuhta Awaiting requested review from Yuhta

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhli1142015 @facebook-github-bot @Yuhta @mbasmanova