Add HiveConnectorSplit Serde #11184
Closed
Add HiveConnectorSplit Serde #11184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
xiaoxmeng
approved these changes
Oct 7, 2024
| } | ||
|
|
||
| std::string HiveConnectorSplit::getFileName() const { | ||
| auto i = filePath.rfind('/'); |
xiaoxmeng
reviewed
Oct 8, 2024
| std::shared_ptr<std::string> extraFileInfo = | ||
| std::make_shared<std::string>(obj["extraFileInfo"].asString()); | ||
| std::unordered_map<std::string, std::string> serdeParameters; | ||
| for (const auto& [key, value] : obj["serdeParameters"].items()) { |
There was a problem hiding this comment.
Do you need to sort based on key? Like #11194 thanks!
|
@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@xiaoxmeng merged this pull request in 2a42006. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add HiveConnectorSplit Serde, a prerequisite for supporting
TableScantracing.part of #9668