Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add include cstdint explicitly #11594

Closed
wants to merge 2 commits into from
Closed

fix: Add include cstdint explicitly #11594

wants to merge 2 commits into from

Conversation

yabinma
Copy link
Contributor

@yabinma yabinma commented Nov 19, 2024

Description:
Without the explicit include, it throws error with gcc 13.2 on Ubuntu 24.04.
The fix is to specify it explicitly.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 19, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 19, 2024 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 97550ae
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/673d1326b9d2110008255bde

@yabinma yabinma mentioned this pull request Nov 19, 2024
Open
czentgr
czentgr reviewed Nov 19, 2024
View reviewed changes
velox/exec/Trace.h
@@ -17,6 +17,7 @@
#pragma once

#include <string>
#include <cstdint>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, the includes should be ordered alphabetically. This PR does the same: #11352

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @czentgr for the review. Added a commit for the re-order.
I am not sure if #11352 is active and when it will be merged.
I am testing the Gluten on Ubuntu 24.04. If the code change can be merged quickly, I am able to start the E2E test as early as possible. Thanks.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That PR should be active. But nonetheless this is ok and perhaps better to have separated out into two PRs.

czentgr
czentgr approved these changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@czentgr czentgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

velox/exec/Trace.h
@@ -17,6 +17,7 @@
#pragma once

#include <string>
#include <cstdint>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That PR should be active. But nonetheless this is ok and perhaps better to have separated out into two PRs.

@czentgr
Copy link
Collaborator

czentgr commented Nov 19, 2024

@majetideepak FYI.

@Yuhta Yuhta added the ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall label Nov 19, 2024
@facebook-github-bot
Copy link
Contributor

@kagamiori has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@kagamiori kagamiori changed the title Fix: Add include cstdint explicitly fix: Add include cstdint explicitly Nov 20, 2024
@facebook-github-bot
Copy link
Contributor

@kagamiori merged this pull request in c13b8ed.

@conbench-facebook conbench-facebook
Copy link

Conbench analyzed the 1 benchmark run on commit c13b8ed8.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czentgr czentgr czentgr approved these changes

@Yuhta Yuhta Yuhta approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yabinma @czentgr @facebook-github-bot @Yuhta