fix(tpch): Fix TPCH benchmark reader crash #11833
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parquet and dwrf reader are registered in TPCH benchmark initialize
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
karthikeyann
changed the title
karthikeyann
requested review from
assignUser and
majetideepak
as code owners
This reverts commit 0bba54d.
majetideepak
approved these changes
Dec 22, 2024
majetideepak
added
the
ready-to-merge
|
@pedroerp has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
athmaja-n
pushed a commit
to athmaja-n/velox
that referenced
this pull request
Jan 10, 2025
Summary: This PR fixes the tpch benchmark crash after new parquet and dwrf readers added. parquet and dwrf reader are registered in benchmark initialize. Tested by running query 1 to 22 on SF10 data, format parquet. Pull Request resolved: facebookincubator#11833 Reviewed By: xiaoxmeng, DanielHunte Differential Revision: D67675533 Pulled By: pedroerp fbshipit-source-id: 2a8fa5c2f3f6a3d6524141d56489530000855810
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the tpch benchmark crash after new parquet and dwrf readers added.
parquet and dwrf reader are registered in benchmark initialize.
Tested by running query 1 to 22 on SF10 data, format parquet.