fix: Returns null for invalid inputs in Spark make_date function #11950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
cc @rui-mo and @liujiayi771 , thanks |
✅ Deploy Preview for meta-velox canceled.
|
zhli1142015
force-pushed
the
make_date_null
branch
from
7d4970c to
7f9fab3
Compare
rui-mo
reviewed
Dec 24, 2024
zhli1142015
force-pushed
the
make_date_null
branch
from
919c09f to
99f7ac2
Compare
rui-mo
changed the title
rui-mo
approved these changes
Dec 27, 2024
rui-mo
added
the
ready-to-merge
|
@zhli1142015 LGTM, thanks. |
zhli1142015
force-pushed
the
make_date_null
branch
4 times, most recently
from
8dc1f24 to
fd6b765
Compare
zhli1142015
force-pushed
the
make_date_null
branch
from
fd6b765 to
94012f8
Compare
|
@kagamiori has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Hi @zhli1142015, could you please rebase the PR onto the latest main? It's needed for merging. Thanks! |
zhli1142015
force-pushed
the
make_date_null
branch
from
94012f8 to
aca0a1f
Compare
Thank you for your help with the merge. The PR has been rebased. |
zhli1142015
force-pushed
the
make_date_null
branch
from
aca0a1f to
9a481b5
Compare
|
@kagamiori has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@kagamiori merged this pull request in 1231ca4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spark make_date function used to throw error for invalid inputs. This PR
changes to return null to conform to Spark ANSI off mode.