Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support decimal type for Spark floor function #11951

Closed
wants to merge 7 commits into from
Closed

feat: Support decimal type for Spark floor function #11951

wants to merge 7 commits into from

Conversation

zhli1142015
Copy link
Contributor

@zhli1142015 zhli1142015 commented Dec 24, 2024 •
edited by rui-mo
Loading

Gluten removed the registration of Presto sql functions. This PR registers
Presto floor function in Spark for reuse.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 24, 2024
@zhli1142015
Copy link
Contributor Author

cc @rui-mo and @PHILO-HE , thanks.

@netlify Netlify
Copy link

netlify bot commented Dec 24, 2024 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit f7cb808
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/677b57fa292e3400080ab9de

@zhli1142015 zhli1142015 changed the title Support decimal type for Spark floor function feat: Support decimal type for Spark floor function Dec 24, 2024
rui-mo
rui-mo reviewed Dec 27, 2024
View reviewed changes
Copy link
Collaborator

@rui-mo rui-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

velox/docs/functions/spark/math.rst Show resolved Hide resolved
@zhli1142015 zhli1142015 requested a review from rui-mo December 27, 2024 05:56
@zhli1142015 zhli1142015 requested a review from rui-mo December 27, 2024 07:35
rui-mo
rui-mo approved these changes Dec 27, 2024
View reviewed changes
Copy link
Collaborator

@rui-mo rui-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good overall.

velox/docs/functions/spark/decimal.rst Outdated Show resolved Hide resolved
velox/docs/functions/spark/decimal.rst Outdated Show resolved Hide resolved
rui-mo
rui-mo reviewed Dec 31, 2024
View reviewed changes
Copy link
Collaborator

@rui-mo rui-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you run the spark_expression_fuzzer_test with velox_fuzzer_enable_decimal_type option enabled? We might need custom argument generator as Presto.

velox/functions/prestosql/fuzzer/FloorAndRoundArgGenerator.h

@zhli1142015
Copy link
Contributor Author

_build/release/velox/expression/fuzzer/spark_expression_fuzzer_test --duration_sec 180 --velox_fuzzer_enable_decimal_type --retry_with_try --logtostderr=1 --minloglevel=0 

E1231 11:39:05.601032 104386 ExpressionFuzzerVerifier.cpp:426] Total iterations: 496115
E1231 11:39:05.601040 104386 ExpressionFuzzerVerifier.cpp:427] Total failed: 33118
[==========] Running 0 tests from 0 test suites.
[==========] 0 tests from 0 test suites ran. (0 ms total)
[  PASSED  ] 0 tests.

@rui-mo rui-mo added the ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall label Jan 6, 2025
@facebook-github-bot
Copy link
Contributor

@kevinwilfong has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@kevinwilfong merged this pull request in b55ef9d.

athmaja-n pushed a commit to athmaja-n/velox that referenced this pull request Jan 10, 2025
@zhli1142015 @athmaja-n
feat: Support decimal type for Spark floor function (facebookincubato…
9061267 
…r#11951)

Summary:
Gluten removed the registration of Presto sql functions. This PR registers
Presto floor function in Spark for reuse.

Pull Request resolved: facebookincubator#11951

Reviewed By: bikramSingh91

Differential Revision: D67867355

Pulled By: kevinwilfong

fbshipit-source-id: a19c35ba0ccd4684b3dc58271fcfc62c029fbe43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rui-mo rui-mo rui-mo approved these changes

@PHILO-HE PHILO-HE PHILO-HE approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhli1142015 @facebook-github-bot @PHILO-HE @rui-mo