fix(sparksql): Consider session timezone when casting timestamp to varchar #11958
+89
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
PHILO-HE
force-pushed
the
fix-timestamp-to-string
branch
from
35a6511 to
003d964
Compare
PHILO-HE
force-pushed
the
fix-timestamp-to-string
branch
from
003d964 to
6015eaf
Compare
PHILO-HE
changed the title
|
@rui-mo, could you take a look? Gluten PR for validation: apache/incubator-gluten#8338. |
rui-mo
reviewed
Dec 27, 2024
rui-mo
approved these changes
Dec 31, 2024
rui-mo
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the behavior of casting timestamp to varchar by considering the
configured timezone. This is for semantic alignment with Spark.