Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix operator addInput stats collection #11960

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Fix operator addInput stats collection #11960

wants to merge 1 commit into from

Conversation

LeonidChistov
Copy link

Fix for #11959

@facebook-github-bot
Copy link
Contributor

Hi @LeonidChistov!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@netlify Netlify
Copy link

netlify bot commented Dec 25, 2024 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit cfbf660
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/67702f0447b1ad000875ce2b

@LeonidChistov
Copy link
Author

@yingsu00 Could you please take a look?

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 25, 2024
@Yuhta Yuhta added the ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall label Dec 27, 2024
@Yuhta Yuhta linked an issue Dec 27, 2024 that may be closed by this pull request
Operator addInput time is aggregated in source operator statistics #11959
Open
@pedroerp
Copy link
Contributor

@LeonidChistov you need to fix the PR title to make CI pass. Please rebase and make sure all jobs are green.

@LeonidChistov LeonidChistov changed the title Fix operator addInput stats collection fix: Fix operator addInput stats collection Dec 28, 2024
@LeonidChistov
Copy link
Author

@pedroerp I have fixed PR title; I think I don't have permissions to restart CI jobs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yuhta Yuhta Yuhta approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Operator addInput time is aggregated in source operator statistics
4 participants
@LeonidChistov @facebook-github-bot @pedroerp @Yuhta